Closed Bug 1416065 Opened 6 years ago Closed 6 years ago

Ensure that override dirty rects are properly removed from frames

Categories

(Core :: Web Painting, enhancement)

Product:
Core
Component:
Web Painting
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: mikokm, Assigned: mikokm)

References

Details

Attachments

(1 file)

Bug 1416065 - Ensure that override dirty rects are properly removed from frames
59 bytes, text/x-review-board-request
mattwoodrow
: review+
Details 
Currently nsDisplayListBuilder::DisplayListBuildingDisplayPortRect() prop can remain on the frames even past RetainedDisplayListBuilder::AttemptPartialUpdate() call.

This patch adds a check that retained pref is toggled before setting DisplayListBuildingDisplayPortRect, and checks if the pref is set for the frames in the modified frames list. This is required because ComputeRebuildRegion() might not get called, and framesWithProps might not contain all the frames with props.
Comment on attachment 8927102 [details]
Bug 1416065 - Ensure that override dirty rects are properly removed from frames

https://reviewboard.mozilla.org/r/198308/#review203542
Attachment #8927102 - Flags: review?(matt.woodrow) → review+
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ad1fdeb7cbb8
Ensure that override dirty rects are properly removed from frames r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/ad1fdeb7cbb8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.