Closed Bug 1416084 Opened 2 years ago Closed 2 years ago

Investigate how bug 1412737 P4 fails to wake up the readers

Categories

(Core :: Audio/Video: Playback, defect, P3)

58 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

Blocks: 1369263
Depends on: 1412737
Version: 56 Branch → 58 Branch
Summary: Investigate how bug 1412737 P4 fails to wake the readers → Investigate how bug 1412737 P4 fails to wake up the readers
Maybe the testing file is smaller than a block size and the OnStopRequest never comes.
I don't think so. OnStopRequest should always fire after receiving all bytes from the server no matter it is a large file or not.
Attachment #8942779 - Flags: review?(bechen)
Attachment #8942780 - Flags: review?(bechen)
Comment on attachment 8942780 [details]
Bug 1416084. P2 - wake up readers when download is suspended.

https://reviewboard.mozilla.org/r/213024/#review218740
Attachment #8942780 - Flags: review?(bechen) → review+
Comment on attachment 8942779 [details]
Bug 1416084. P1 - reapply bug 1412737 P4: wake up readers only when we have blocks committed to the cache.

https://reviewboard.mozilla.org/r/213022/#review218742
Attachment #8942779 - Flags: review?(bechen) → review+
Attachment #8942779 - Flags: review?(gsquelart)
Attachment #8942780 - Flags: review?(gsquelart)
Assignee: nobody → jwwang
Comment on attachment 8942779 [details]
Bug 1416084. P1 - reapply bug 1412737 P4: wake up readers only when we have blocks committed to the cache.

https://reviewboard.mozilla.org/r/213022/#review218748
Attachment #8942779 - Flags: review?(gsquelart) → review+
Comment on attachment 8942779 [details]
Bug 1416084. P1 - reapply bug 1412737 P4: wake up readers only when we have blocks committed to the cache.

https://reviewboard.mozilla.org/r/213022/#review218750

::: commit-message-21ddf:1
(Diff revision 1)
> +Bug 1416084. P1 - reapply bug 1412737 P4.

Actually, could you please include the commit message from that patch?
(When browsing the code through SearchFox or other, it's more informative than having to go hunt for the bug!)
Comment on attachment 8942780 [details]
Bug 1416084. P2 - wake up readers when download is suspended.

https://reviewboard.mozilla.org/r/213024/#review218752
Attachment #8942780 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3ca97a44f1c
P1 - reapply bug 1412737 P4: wake up readers only when we have blocks committed to the cache. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/4ae35d2b108a
P2 - wake up readers when download is suspended. r=bechen,gerald
https://hg.mozilla.org/mozilla-central/rev/e3ca97a44f1c
https://hg.mozilla.org/mozilla-central/rev/4ae35d2b108a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.