Closed Bug 1416086 Opened 2 years ago Closed 2 years ago

Many builds are broken on Beta58 from ClientManager.cpp Werror failures

Categories

(Core :: DOM: Service Workers, defect, blocker)

58 Branch
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 blocking fixed

People

(Reporter: RyanVM, Assigned: bkelly)

References

Details

(Keywords: regression)

Attachments

(1 file)

[Tracking Requested - why for this release]: Broken builds

This is going to block shipping any new builds off Beta until fixed.

https://treeherder.mozilla.org/logviewer.html#?job_id=143478592&repo=mozilla-beta
Flags: needinfo?(bkelly)
I assume this is some MOZ_DIAGNOSTIC_ASSERT() related thing causing a variable to become unused.  Sorry.  I'll fix.
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Flags: needinfo?(bkelly)
Andrea, this avoids creating variables that will be unused when diagnostic assertions are disabled.

Ryan, do you have a convenient way to test this in the beta configuration?  I'm not sure how to configure that and I don't have the fastest machine with me while traveling to do a lot of builds.
Attachment #8927236 - Flags: review?(amarchesini)
Attachment #8927236 - Flags: feedback?(ryanvm)
Comment on attachment 8927236 [details] [diff] [review]
Fix unused variable warnings when diagnostic assertions are disabled. r=baku

Review of attachment 8927236 [details] [diff] [review]:
-----------------------------------------------------------------

Would be nice to have a DebugDiagnosticOnly class as we do have for DebugOnly.
Attachment #8927236 - Flags: review?(amarchesini) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29c29825ff3a
Fix unused variable warnings when diagnostic assertions are disabled. r=baku
https://hg.mozilla.org/mozilla-central/rev/29c29825ff3a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Attachment #8927236 - Flags: feedback?(ryanvm) → feedback+
You need to log in before you can comment on or make changes to this bug.