Closed Bug 1416094 Opened 7 years ago Closed 6 years ago

Test

Categories

(Toolkit :: Safe Browsing, enhancement, P5)

Product:
Toolkit
Component:
Safe Browsing
Type:
enhancement

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: dlee, Unassigned)

Details

Attachments

(1 file, 10 obsolete files)

Bug 1416094 - Test
59 bytes, text/x-review-board-request
Details 
This is for test only
Comment on attachment 8927128 [details]
Bug 1416094 - WIP backup

https://reviewboard.mozilla.org/r/198350/#review204038


C/C++ static analysis found 3 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: toolkit/components/reputationservice/LoginReputation.cpp:107
(Diff revision 3)
> +    return ReputationPromise::CreateAndReject(NS_ERROR_ABORT, __func__);
> +  }
> +
> +  RefPtr<RemoteLookup> self = this;
> +
> +  return InvokeAsync(mThread, __func__, [self, aParam]() {

Error: Refcounted variable 'aparam' of type 'iloginreputationquery' cannot be captured by a lambda [clang-tidy: mozilla-refcounted-inside-lambda]

::: toolkit/components/reputationservice/LoginReputation.cpp:197
(Diff revision 3)
> +    return ReputationPromise::CreateAndReject(NS_ERROR_ABORT, __func__);
> +  }
> +
> +  RefPtr<TrustBasedWhitelisting> self = this;
> +
> +  return InvokeAsync(mThread, __func__, [self, aParam]() {

Error: Refcounted variable 'aparam' of type 'iloginreputationquery' cannot be captured by a lambda [clang-tidy: mozilla-refcounted-inside-lambda]

::: toolkit/components/reputationservice/LoginReputation.cpp:281
(Diff revision 3)
> +                             const nsACString& aProvider,
> +                             const nsACString& aFullHash)
> +{
> +  MOZ_ASSERT(NS_IsMainThread());
> +
> +  int64_t now = PR_Now() / PR_USEC_PER_MSEC;

Warning: Value stored to 'now' during its initialization is never read [clang-tidy: clang-analyzer-deadcode.DeadStores]
Comment on attachment 8927128 [details]
Bug 1416094 - WIP backup

https://reviewboard.mozilla.org/r/198350/#review204058


C/C++ static analysis found 3 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: toolkit/components/reputationservice/LoginReputation.cpp:107
(Diff revision 3)
> +    return ReputationPromise::CreateAndReject(NS_ERROR_ABORT, __func__);
> +  }
> +
> +  RefPtr<RemoteLookup> self = this;
> +
> +  return InvokeAsync(mThread, __func__, [self, aParam]() {

Error: Refcounted variable 'aparam' of type 'iloginreputationquery' cannot be captured by a lambda [clang-tidy: mozilla-refcounted-inside-lambda]

::: toolkit/components/reputationservice/LoginReputation.cpp:197
(Diff revision 3)
> +    return ReputationPromise::CreateAndReject(NS_ERROR_ABORT, __func__);
> +  }
> +
> +  RefPtr<TrustBasedWhitelisting> self = this;
> +
> +  return InvokeAsync(mThread, __func__, [self, aParam]() {

Error: Refcounted variable 'aparam' of type 'iloginreputationquery' cannot be captured by a lambda [clang-tidy: mozilla-refcounted-inside-lambda]

::: toolkit/components/reputationservice/LoginReputation.cpp:281
(Diff revision 3)
> +                             const nsACString& aProvider,
> +                             const nsACString& aFullHash)
> +{
> +  MOZ_ASSERT(NS_IsMainThread());
> +
> +  int64_t now = PR_Now() / PR_USEC_PER_MSEC;

Warning: Value stored to 'now' during its initialization is never read [clang-tidy: clang-analyzer-deadcode.DeadStores]
Attachment #8927128 - Attachment is obsolete: true
Attachment #8932341 - Attachment is obsolete: true
Attachment #8931241 - Flags: review?(tnguyen)
Comment on attachment 8931241 [details]
Bug 1416094 - Force an update when safebrowsing tables are changed in preference.

https://reviewboard.mozilla.org/r/202370/#review209234
Attachment #8931241 - Flags: review?(tnguyen) → review+
Attachment #8931241 - Attachment is obsolete: true
Attachment #8931241 - Flags: review?(francois)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Telemetry::APPLICATION_REPUTATION_REMOTE_LOOKUP_RESPONSE_TIME can be
used to give us an idea how could we adjust the timeout accordingly.
3% download protection remote lookup failures are from timeout.
Increase the timeout from 10sec to 15sec to see if this help.
Attachment #9007213 - Attachment is obsolete: true
Attachment #9007211 - Attachment is obsolete: true
Attachment #9007210 - Attachment is obsolete: true
Attached file Bug 1416094 - p1 test (obsolete) — 
aaa
Attachment #9017043 - Attachment is obsolete: true
Reviewers: gcp

Tags: #secure-revision

Bug #: 1517704

Differential Revision: https://phabricator.services.mozilla.com/D15804
Attachment #9037422 - Attachment is obsolete: true
Attached file Bug 1416094 - V1 (obsolete) —
Attached file Hello (obsolete) —

Depends on D37263

Attachment #9076553 - Attachment description: Bug 1416094 - V2 → Bug 1416094 - Testtestsetestset
Attachment #9076553 - Attachment description: Bug 1416094 - Testtestsetestset → Hello
Attachment #9076553 - Attachment is obsolete: true
Attachment #9076552 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: