Closed
Bug 1416156
Opened 8 years ago
Closed 8 years ago
Update Authentication XCUITests to new FxScreenGraph
Categories
(Firefox for iOS :: Build & Test, defect, P1)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
References
Details
Attachments
(1 file)
These tests fail with error:
- Cannot route from PasscodeSettings to PasscodeIntervalSettings
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → irios.mozilla
|
||
Updated•8 years ago
|
Priority: -- → P1
|
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•8 years ago
|
||
Asking for r?
Authentication Tests are now green:
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a0b06cb2705820001a08349#logs
Attachment #8928219 -
Flags: review?(npark)
Attachment #8928219 -
Flags: review?(jhugman)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8928219 [details] [review]
Pull Request
LGTM
Attachment #8928219 -
Flags: review?(npark) → review+
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8928219 [details] [review]
Pull Request
Some changes requested, but otherwise on the right track.
Attachment #8928219 -
Flags: review?(jhugman) → feedback+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8928219 -
Flags: review?(jhugman)
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8928219 [details] [review]
Pull Request
A few more nits, but LGTM, well done.
Attachment #8928219 -
Flags: review?(jhugman) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Thanks for the reviews!
Merged: https://github.com/mozilla-mobile/firefox-ios/commit/d1a1cba9c01cbe511668671008ffebb3e1a4646e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•