Closed Bug 1416199 Opened 2 years ago Closed 2 years ago

Don't set signal handlers to dump/reset coverage counters on Windows

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

We will support dumping counters on demand using signals only on Linux for now.
Attached patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8927288 - Flags: review?(nfroyd)
Comment on attachment 8927288 [details] [diff] [review]
Patch

Review of attachment 8927288 [details] [diff] [review]:
-----------------------------------------------------------------

WFM!
Attachment #8927288 - Flags: review?(nfroyd) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/353999bc9b73
Don't try to set signal handlers in Windows coverage build. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/353999bc9b73
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.