Closed Bug 1416249 Opened 2 years ago Closed 2 years ago

Remove conditional catch consumers in devtools/.

Categories

(DevTools :: General, enhancement, P3, minor)

enhancement

Tracking

(firefox58 fix-optional, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox58 --- fix-optional
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

non-standard conditional catch syntax is going to be removed in bug 1228841.

there are 2 cases for replacement.

case 1: only conditional catch

from:
  try {
    A
  } catch (e if cond) {
    B
  }
to
  try {
    A
  } catch (e) {
    if (!cond) {
      throw e;
    }
    B
  }

case 2: conditional catch and unconditional catch

from:
  try {
    A
  } catch (e if cond) {
    B
  } catch {
    C
  }
to
  try {
    A
  } catch (e) {
    if (cond) {
      B
    } else {
      C
    }
  }
Priority: -- → P3
Attachment #8928549 - Flags: review?(jmaher) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ec21245c48
Remove conditional catch consumers in devtools/. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/49ec21245c48
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.