Closed
Bug 1416249
Opened 7 years ago
Closed 7 years ago
Remove conditional catch consumers in devtools/.
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox58 fix-optional, firefox59 fixed)
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox58 | --- | fix-optional |
firefox59 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
1.02 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
non-standard conditional catch syntax is going to be removed in bug 1228841. there are 2 cases for replacement. case 1: only conditional catch from: try { A } catch (e if cond) { B } to try { A } catch (e) { if (!cond) { throw e; } B } case 2: conditional catch and unconditional catch from: try { A } catch (e if cond) { B } catch { C } to try { A } catch (e) { if (cond) { B } else { C } }
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8928549 -
Flags: review?(jmaher)
Updated•7 years ago
|
Attachment #8928549 -
Flags: review?(jmaher) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/49ec21245c48 Remove conditional catch consumers in devtools/. r=jmaher
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ec21245c48ca0f4b7b1ee370a7ccfd3024140c Bug 1416249 - Remove conditional catch consumers in devtools/. r=jmaher
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49ec21245c48
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•