Closed Bug 1416251 Opened 6 years ago Closed 6 years ago

Remove conditional catch consumers in mobile/android/.

Categories

(Firefox for Android Graveyard :: General, enhancement, P2)

Product:
Firefox for Android Graveyard
Component:
General
Type:
enhancement

Tracking

(firefox58 wontfix, firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Remove conditional catch consumers in mobile/android/.
2.64 KB, patch
cnevinchen
: review+
Details | Diff | Splinter Review 
non-standard conditional catch syntax is going to be removed in bug 1228841.

there are 2 cases for replacement.

case 1: only conditional catch

from:
  try {
    A
  } catch (e if cond) {
    B
  }
to
  try {
    A
  } catch (e) {
    if (!cond) {
      throw e;
    }
    B
  }

case 2: conditional catch and unconditional catch

from:
  try {
    A
  } catch (e if cond) {
    B
  } catch {
    C
  }
to
  try {
    A
  } catch (e) {
    if (cond) {
      B
    } else {
      C
    }
  }
I t
Priority: -- → P2
Attachment #8928551 - Flags: review?(s.kaspari) → review?(cnevinchen)
Attachment #8928551 - Flags: review?(cnevinchen) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76bdc9a9451d
Remove conditional catch consumers in mobile/android/. r=nechen
https://hg.mozilla.org/integration/mozilla-inbound/rev/76bdc9a9451de58725f2f31553d4b22bae3694d1
Bug 1416251 - Remove conditional catch consumers in mobile/android/. r=nechen
https://hg.mozilla.org/mozilla-central/rev/76bdc9a9451d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.