tls13con.c fix signed / unsigned compilation warnings

ASSIGNED
Assigned to

Status

NSS
Libraries
ASSIGNED
14 days ago
23 hours ago

People

(Reporter: jbonnafo, Assigned: jbonnafo)

Tracking

trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 days ago
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171024165158

Steps to reproduce:

Using Visual studio 2017 compiler, compilation of tls3con.c generates warnings.




Actual results:

Generated warnings are:
security/nss/lib/ssl/tls13con.c:1669 [C4018] '<': signed/unsigned mismatch
security/nss/lib/ssl/tls13con.c:4135 [C4018] '>': signed/unsigned mismatch
security/nss/lib/ssl/tls13con.c:4140 [C4018] '<': signed/unsigned mismatch
security/nss/lib/ssl/tls13con.c:4401 [C4018] '>': signed/unsigned mismatch


Expected results:

Code should compile without any compiler warning.
(Assignee)

Comment 1

14 days ago
Another solution could be to change signature of tls13_Read0RttData function in order to have:

PRUint32
tls13_Read0RttData(sslSocket *ss, void *buf, PRUint32 len)

but this signature change would also impact some other functions.
Assignee: nobody → jeanluc.bonnafoux
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 2

a day ago
Hello,

Could you please assign this issue to me?

Thanks,
Hey Jean-Luc, this bug is already assigned to you :)
(Assignee)

Comment 4

23 hours ago
Oh sorry, i should have noticed !
You need to log in before you can comment on or make changes to this bug.