1416290 - Update iPad XCUITest to new FxScreenGraph

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

There are some tests failing only on iPad simulator becuase it is not possible to route from one screen to a different one, for example: 

ReaderViewTests: 
- testAddToReadingList():  Cannot route from HomePanel.ReadingList.3 to BrowserTab

SearchTests:
- testCopyPasteComplete():  Cannot route from HomePanels to URLBarOpen

There are a few more failing due to routes only in iPad not in iPhone.

Seems like somehow for iPad we are missing some checks for the correct routing

Comment 1

[Isabel Rios[:isabel_rios]]

After investigating this issue, it seems that this check for the iPad case is not working totally fine: 
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/FxScreenGraph.swift#L310

Would you be fine if we change that part doing this:
if isTablet {
            screenState.tap(app.buttons["TopTabsViewController.tabsButton"], to: TabTray)
        } else {
            screenState.gesture(to: TabTray) {
                if (app.buttons["TabToolbar.tabsButton"].exists) {
                    app.buttons["TabToolbar.tabsButton"].tap()
                } else {
                    app.buttons["URLBarView.tabsButton"].tap()
                }
            }
        }

The failing tests are working this way, but not sure if that is correct with the new FxScreenGraph and the consistency of it.
Please let me know your thoughts, thanks!

Comment 2

[James Hugman [:jhugman] [@jhugman]]

You've exposed a bug — in its current form, each pair of nodes can only have one edge between them, so multiple edges overwrite one another. I've filed Bug 1417522 to track if this becomes more of a problem — please add more examples to that bug to build some more usecases.

The workaround is to do as you've done.

Comment 3

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Tests affected by the routing are now passing, this error is not shown...
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5a0d61616e193700010185bb#tests

(The failures are due to other bugs being worked on or under investigation)

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8928961 [details] [review]
Pull Request

LGTM

Comment 5

[Isabel Rios[:isabel_rios]]

Merged: https://github.com/mozilla-mobile/firefox-ios/commit/c73fb8c20b5f00f40ad6c19c1dbc24e6ec1992f7