1416316 - Provide NativePanZoomController API

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

For the session to accept touch/motion events, I think the session class should provide a NativePanZoomController getter, e.g. `LayerSession.getPanZoomController()`, which returns a NativePanZoomController instance.

We should clean up NativePanZoomController so its only public methods are documented APIs, e.g. `NativePanZoomController.onTouchEvent()`, which correctly handle edge cases like before the Compositor is ready, etc.

Finally, we should have GeckoView use the API, e.g.

> @Override
> public boolean onTouchEvent(final MotionEvent event) {
>     if (mSession != null) {
>         mSession.getPanZoomController().onTouchEvent(event);
>     }
> }

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1416316 - 1. Move overscroll to LayerSession;

There is some overscroll handling code in NativePanZoomController that
should be moved, along with other overscroll code in LayerView, to
LayerSession. LayerSession now provides a getter for
OverscrollEdgeEffect, which is cleaned up to have a public API with
documentation.

Review commit: https://reviewboard.mozilla.org/r/204104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204104/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1416316 - 2. Clean up NativePanZoomController;

Clean up the NativePanZoomController object including,

1) Remove references to LayerView because NPZC will be created and used
by LayerSession.

2) Rename `mDestroyed` to `mAttached` because NPZC now needs to support
cases where it's used before being attached, in addition to after being
destroyed.

3) Move origin of synthesized event coordinates from the screen to the
surface in native code, so we don't need to do the same thing in Java.

4) Invoke all callbacks from native code on the UI thread.

Review commit: https://reviewboard.mozilla.org/r/204106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204106/

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1416316 - 3. Update NPZC usages;

Remove NPZC references from LayerView, and add an NPZC getter in
LayerSession. Use the new APIs in GeckoView to forward events to NPZC.

Review commit: https://reviewboard.mozilla.org/r/204108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204108/

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1416316 - 4. Update comments and bindings;

Review commit: https://reviewboard.mozilla.org/r/204110/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/204110/

Comment 5

[Randall Barker [:rbarker]]

Comment on attachment 8933136 [details]
Bug 1416316 - 1. Move overscroll to LayerSession;

https://reviewboard.mozilla.org/r/204104/#review209842

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8933137 [details]
Bug 1416316 - 2. Clean up NativePanZoomController;

https://reviewboard.mozilla.org/r/204106/#review209844

Comment 7

[Randall Barker [:rbarker]]

Comment on attachment 8933138 [details]
Bug 1416316 - 3. Update NPZC usages;

https://reviewboard.mozilla.org/r/204108/#review209852

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8933136 [details]
Bug 1416316 - 1. Move overscroll to LayerSession;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204104/diff/1-2/

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8933137 [details]
Bug 1416316 - 2. Clean up NativePanZoomController;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204106/diff/1-2/

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8933138 [details]
Bug 1416316 - 3. Update NPZC usages;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204108/diff/1-2/

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8933139 [details]
Bug 1416316 - 4. Update comments and bindings;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/204110/diff/1-2/

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8933139 [details]
Bug 1416316 - 4. Update comments and bindings;

https://reviewboard.mozilla.org/r/204110/#review209930

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7abdb31418e
1. Move overscroll to LayerSession; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/70246e37dfc8
2. Clean up NativePanZoomController; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/e177b3dd4380
3. Update NPZC usages; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/e23185b58116
4. Update comments and bindings; r=jchen

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d7abdb31418e
https://hg.mozilla.org/mozilla-central/rev/70246e37dfc8
https://hg.mozilla.org/mozilla-central/rev/e177b3dd4380
https://hg.mozilla.org/mozilla-central/rev/e23185b58116