Closed Bug 1416316 Opened 4 years ago Closed 4 years ago

Provide NativePanZoomController API

Categories

(GeckoView :: General, enhancement)

All
Android
enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(4 files)

For the session to accept touch/motion events, I think the session class should provide a NativePanZoomController getter, e.g. `LayerSession.getPanZoomController()`, which returns a NativePanZoomController instance.

We should clean up NativePanZoomController so its only public methods are documented APIs, e.g. `NativePanZoomController.onTouchEvent()`, which correctly handle edge cases like before the Compositor is ready, etc.

Finally, we should have GeckoView use the API, e.g.

> @Override
> public boolean onTouchEvent(final MotionEvent event) {
>     if (mSession != null) {
>         mSession.getPanZoomController().onTouchEvent(event);
>     }
> }
No longer blocks: 1415994
Depends on: 1415994
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Comment on attachment 8933136 [details]
Bug 1416316 - 1. Move overscroll to LayerSession;

https://reviewboard.mozilla.org/r/204104/#review209842
Attachment #8933136 - Flags: review?(rbarker) → review+
Comment on attachment 8933137 [details]
Bug 1416316 - 2. Clean up NativePanZoomController;

https://reviewboard.mozilla.org/r/204106/#review209844
Attachment #8933137 - Flags: review?(rbarker) → review+
Comment on attachment 8933138 [details]
Bug 1416316 - 3. Update NPZC usages;

https://reviewboard.mozilla.org/r/204108/#review209852
Attachment #8933138 - Flags: review?(rbarker) → review+
Comment on attachment 8933139 [details]
Bug 1416316 - 4. Update comments and bindings;

https://reviewboard.mozilla.org/r/204110/#review209930
Attachment #8933139 - Flags: review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7abdb31418e
1. Move overscroll to LayerSession; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/70246e37dfc8
2. Clean up NativePanZoomController; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/e177b3dd4380
3. Update NPZC usages; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/e23185b58116
4. Update comments and bindings; r=jchen
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 59 → mozilla59
You need to log in before you can comment on or make changes to this bug.