Closed Bug 1416321 Opened 4 years ago Closed 4 years ago

Schedule a full sync after we successfully connect to a captive portal

Categories

(Firefox :: Sync, enhancement)

Product:
Firefox
Component:
Sync
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: eoger, Assigned: eoger)

References

Details

Attachments

(1 file)

Bug 1416321 - Do a sync after we successfully connect to a captive portal.
59 bytes, text/x-review-board-request
markh
: review+
Details 
The event we need to listen to is "captive-portal-login-success".
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Comment on attachment 8927432 [details]
Bug 1416321 - Do a sync after we successfully connect to a captive portal.

https://reviewboard.mozilla.org/r/198748/#review203990

This is an improvement to the status quo, but it seems like we should still be doing a little more (eg, not scheduling syncs while we are in a captive portal) in a followup.

::: services/sync/modules/policies.js:333
(Diff revision 1)
>          break;
> +      case "captive-portal-login-success":
> +        this._log.debug("Captive portal login success. Scheduling a sync.");
> +        CommonUtils.nextTick(() => {
> +          this.scheduleNextSync(3000);
> +        });

add a "break"
Attachment #8927432 - Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2af71f8e9ca3
Do a sync after we successfully connect to a captive portal. r=markh
See Also: → 1416807
https://hg.mozilla.org/mozilla-central/rev/2af71f8e9ca3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.