Closed
Bug 1416322
Opened 7 years ago
Closed 7 years ago
Schedule a full sync after the computer wakes up from sleeping and the network is back up
Categories
(Firefox :: Sync, enhancement, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: eoger, Assigned: eoger)
References
Details
Attachments
(1 file)
In bug 1197625 the implementation did not take in account the link state. We should try to do more and sync only when we're back online (WiFi can take more than 5 seconds to connect).
Updated•7 years ago
|
Assignee: nobody → eoger
Priority: -- → P2
Summary: Schedule a full sync after the computer wakes up from sleeping → Schedule a full sync after the computer wakes up from sleeping and the network is back up
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8929085 [details] Bug 1416322 - Wait until the network is back up to sync after waking-up from sleep. https://reviewboard.mozilla.org/r/200380/#review205776 ::: services/sync/modules/policies.js:377 (Diff revision 1) > // Trigger a sync if we have multiple clients. We give it 5 seconds > // incase the network is still in the process of coming back up. > if (this.numClients > 1) { > - this._log.debug("More than 1 client. Will sync in 5s."); > + if (!this.offline) { > + this._log.debug("Online, will sync in 5s."); > - this.scheduleNextSync(5000); > + this.scheduleNextSync(5000); I'd be inclined to drop this to say 2 seconds, and the comment above should be adjusted, as the delay is no longer about the network but (in my mind) more about giving Firefox itself time to recover from the wake and do whatever else it thinks is important, such as firing pending timers etc) TBH, I don't feel strongly about the delay, but the comment should change in some way.
Attachment #8929085 -
Flags: review?(markh) → review+
Comment hidden (mozreview-request) |
Pushed by eoger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/394ad92e2392 Wait until the network is back up to sync after waking-up from sleep. r=markh
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/394ad92e2392
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•