1416322 - Schedule a full sync after the computer wakes up from sleeping and the network is back up

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P2)

Description

[Edouard Oger [:eoger]]

In bug 1197625 the implementation did not take in account the link state.
We should try to do more and sync only when we're back online (WiFi can take more than 5 seconds to connect).

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1416322 - Wait until the network is back up to sync after waking-up from sleep.

Review commit: https://reviewboard.mozilla.org/r/200380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200380/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8929085 [details]
Bug 1416322 - Wait until the network is back up to sync after waking-up from sleep.

https://reviewboard.mozilla.org/r/200380/#review205776

::: services/sync/modules/policies.js:377
(Diff revision 1)
>            // Trigger a sync if we have multiple clients. We give it 5 seconds
>            // incase the network is still in the process of coming back up.
>            if (this.numClients > 1) {
> -            this._log.debug("More than 1 client. Will sync in 5s.");
> +            if (!this.offline) {
> +              this._log.debug("Online, will sync in 5s.");
> -            this.scheduleNextSync(5000);
> +              this.scheduleNextSync(5000);

I'd be inclined to drop this to say 2 seconds, and the comment above should be adjusted, as the delay is no longer about the network but (in my mind) more about giving Firefox itself time to recover from the wake and do whatever else it thinks is important, such as firing pending timers etc)

TBH, I don't feel strongly about the delay, but the comment should change in some way.

Comment 3

[Edouard Oger [:eoger]]

Comment on attachment 8929085 [details]
Bug 1416322 - Wait until the network is back up to sync after waking-up from sleep.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200380/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/394ad92e2392
Wait until the network is back up to sync after waking-up from sleep. r=markh

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/394ad92e2392