1416339 - Forced unwraps in QRCodeViewController causing crashes

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Justin D'Arcangelo [:justindarc]]

Forced unwraps in QRCodeViewController seem to be causing crashes like this:

Exception Type:  EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000001, 0x000000010060cbe0
Termination Signal: Trace/BPT trap: 5
Termination Reason: Namespace SIGNAL, Code 0x5
Terminating Process: exc handler [0]
Triggered by Thread:  0

Thread 0 name:
Thread 0 Crashed:
0   Client                        	0x000000010060cbe0 specialized closure #2 in QRCodeViewController.captureOutput(_:didOutputMetadataObjects:from:) + 328 (QRCodeViewController.swift:223)
1   Client                        	0x000000010060d838 partial apply for closure #2 in QRCodeViewController.captureOutput(_:didOutputMetadataObjects:from:) + 56 (QRCodeViewController.swift:0)
2   Client                        	0x00000001005302a8 thunk for @callee_owned () -> () + 36 (AppSettingsTableViewController.swift:0)
3   UIKit                         	0x000000018fbc5534 -[UIPresentationController transitionDidFinish:] + 1320 (UIPresentationController.m:313)
4   UIKit                         	0x000000018fda79f8 -[_UICurrentContextPresentationController transitionDidFinish:] + 44 (_UICurrentContextPresentationController.m:81)
5   UIKit                         	0x000000018fbc91d4 __56-[UIPresentationController runTransitionForCurrentState]_block_invoke_2 + 188 (UIPresentationController.m:809)
6   UIKit                         	0x000000018f98ef30 -[_UIViewControllerTransitionContext completeTransition:] + 116 (UIViewControllerTransitioning.m:283)
7   UIKit                         	0x000000018f98ed20 -[UITransitionView notifyDidCompleteTransition:] + 252 (UITransitionView.m:269)
8   UIKit                         	0x000000018f98e7b8 -[UITransitionView _didCompleteTransition:] + 1128 (UITransitionView.m:238)
9   UIKit                         	0x000000018f98e33c -[UITransitionView _transitionDidStop:finished:] + 120 (UITransitionView.m:736)
10  UIKit                         	0x000000018f8b4b14 -[UIViewAnimationState sendDelegateAnimationDidStop:finished:] + 312 (UIView.m:0)
11  UIKit                         	0x000000018f8b4820 -[UIViewAnimationState animationDidStop:finished:] + 296 (UIView.m:1979)
12  UIKit                         	0x000000018f8b48c0 -[UIViewAnimationState animationDidStop:finished:] + 456 (UIView.m:1998)
13  QuartzCore                    	0x000000018a442b80 CA::Layer::run_animation_callbacks(void*) + 284 (CALayer.mm:6573)
14  libdispatch.dylib             	0x0000000185dc9048 _dispatch_client_callout + 16 (object.m:502)
15  libdispatch.dylib             	0x0000000185dd5b74 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1016 (inline_internal.h:2500)
16  CoreFoundation                	0x00000001863edeb0 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12 (CFRunLoop.c:1815)
17  CoreFoundation                	0x00000001863eba8c __CFRunLoopRun + 2012 (CFRunLoop.c:3111)
18  CoreFoundation                	0x000000018630bfb8 CFRunLoopRunSpecific + 436 (CFRunLoop.c:3245)
19  GraphicsServices              	0x00000001881a3f84 GSEventRunModal + 100 (GSEvent.c:2245)
20  UIKit                         	0x000000018f8e02f4 UIApplicationMain + 208 (UIApplication.m:3949)
21  Client                        	0x0000000100526798 main + 296 (main.swift:16)
22  libdyld.dylib                 	0x0000000185e2e56c start + 4

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 2

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/772ffcc635092591a02de95f5d054f519c5f6c0b

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/87462bb9bac5376160ea985c0cfe79e36ffb29fb