Crash: SwipeAnimator.animateAwayWithVelocity

RESOLVED FIXED

Status

()

Firefox for iOS
General
P1
normal
RESOLVED FIXED
12 days ago
9 days ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.2)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 days ago
We're seeing the following crash in the Xcode crash reporter:

Hardware Model:      iPhone8,2
Identifier:          org.mozilla.ios.Firefox
Version:             7617 (10.0)
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           org.mozilla.ios.Firefox [963]

Date/Time:           2017-11-08 22:59:16.4659 +0100
Launch Time:         2017-11-08 22:55:44.8475 +0100
OS Version:          iPhone OS 11.1 (15B93)
Baseband Version:    4.00.01
Report Version:      104

Exception Type:  EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000001, 0x0000000104913cf8
Termination Signal: Trace/BPT trap: 5
Termination Reason: Namespace SIGNAL, Code 0x5
Terminating Process: exc handler [0]
Triggered by Thread:  0

Thread 0 name:
Thread 0 Crashed:
0   Client                        	0x0000000104913cf8 specialized Array._checkSubscript(_:wasNativeTypeChecked:) + 44 (TopTabsViewController.swift:0)
1   Client                        	0x000000010495170c specialized TabTrayController.swipeAnimator(_:viewWillExitContainerBounds:) + 660 (TabTrayController.swift:0)
2   Client                        	0x000000010494729c @objc TabTrayController.swipeAnimator(_:viewWillExitContainerBounds:) + 56 (TabTrayController.swift:0)
3   Client                        	0x00000001049472f0 protocol witness for SwipeAnimatorDelegate.swipeAnimator(_:viewWillExitContainerBounds:) in conformance TabTrayController + 48 (TabTrayController.swift:0)
4   Client                        	0x0000000104ae328c specialized SwipeAnimator.animateAwayWithVelocity(_:speed:) + 480 (SwipeAnimator.swift:72)
5   Client                        	0x0000000104ae2c64 @objc SwipeAnimator.close(right:) + 108 (SwipeAnimator.swift:0)
6   Client                        	0x0000000104ae2ce0 @objc SwipeAnimator.closeWithoutGesture() + 48 (SwipeAnimator.swift:137)
7   Client                        	0x0000000104941b1c @objc TabCell.close() + 140 (TabTrayController.swift:220)
8   UIKit                         	0x000000018b535614 -[UIApplication sendAction:to:from:forEvent:] + 96 (UIApplication.m:4440)
9   UIKit                         	0x000000018b535594 -[UIControl sendAction:to:forEvent:] + 80 (UIControl.m:619)
10  UIKit                         	0x000000018b5202fc -[UIControl _sendActionsForEvents:withEvent:] + 440 (UIControl.m:702)
11  UIKit                         	0x000000018b534e88 -[UIControl touchesEnded:withEvent:] + 576 (UIControl.m:456)
12  UIKit                         	0x000000018bb8b084 _UIGestureEnvironmentSortAndSendDelayedTouches + 4280 (UIGestureEnvironment.m:0)
13  UIKit                         	0x000000018bb86634 _UIGestureEnvironmentUpdate + 1224 (UIGestureEnvironment.m:172)
14  UIKit                         	0x000000018bb86118 -[UIGestureEnvironment _deliverEvent:toGestureRecognizers:usingBlock:] + 404 (UIGestureEnvironment.m:1213)
15  UIKit                         	0x000000018bb85274 -[UIGestureEnvironment _updateGesturesForEvent:window:] + 276 (UIGestureEnvironment.m:1108)
16  UIKit                         	0x000000018b52fe5c -[UIWindow sendEvent:] + 3180 (UIWindow.m:2262)
17  UIKit                         	0x000000018b501384 -[UIApplication sendEvent:] + 340 (UIApplication.m:10340)
18  UIKit                         	0x000000018be4e85c __dispatchPreprocessedEventFromEventQueue + 2364 (UIEventDispatcher.m:1445)
19  UIKit                         	0x000000018be50de8 __handleEventQueueInternal + 4760 (UIEventDispatcher.m:1691)
20  UIKit                         	0x000000018be49d04 __handleHIDEventFetcherDrain + 152 (UIEventDispatcher.m:1659)
21  CoreFoundation                	0x00000001820722e8 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24 (CFRunLoop.c:1982)
22  CoreFoundation                	0x0000000182072268 __CFRunLoopDoSource0 + 88 (CFRunLoop.c:2017)
23  CoreFoundation                	0x0000000182071af0 __CFRunLoopDoSources0 + 204 (CFRunLoop.c:2053)
24  CoreFoundation                	0x000000018206f6c8 __CFRunLoopRun + 1048 (CFRunLoop.c:2920)
25  CoreFoundation                	0x0000000181f8ffb8 CFRunLoopRunSpecific + 436 (CFRunLoop.c:3245)
26  GraphicsServices              	0x0000000183e27f84 GSEventRunModal + 100 (GSEvent.c:2245)
27  UIKit                         	0x000000018b5642f4 UIApplicationMain + 208 (UIApplication.m:3949)
28  Client                        	0x00000001048ae798 main + 296 (main.swift:16)
29  libdyld.dylib                 	0x0000000181ab256c start + 4
(Assignee)

Updated

12 days ago
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
tracking-fxios: ? → 10.2
Priority: -- → P1
(Assignee)

Comment 1

12 days ago
Created attachment 8927459 [details] [review]
GitHub Pull Request
Attachment #8927459 - Flags: review?(fpatel)

Updated

11 days ago
Attachment #8927459 - Flags: review?(fpatel) → review+
(Assignee)

Comment 2

9 days ago
Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/ba67c0a4063d54405937758292b6131a68c22392

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/1dc7f07662d592fc7ac9dc7b98dd913258f427b4
Status: ASSIGNED → RESOLVED
Last Resolved: 9 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.