Closed Bug 1416368 Opened 4 years ago Closed 4 years ago

Remove unused statusbarpanel-* bindings

Categories

(Toolkit :: XUL Widgets, task)

Product:
Toolkit
Component:
XUL Widgets
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Whiteboard: [xbl-remove-unused])

Attachments

(2 files)

Bug 1416368 - Remove unused statusbarpanel-* bindings;
59 bytes, text/x-review-board-request
dao
: review+
Details
Bug 1416368 - Remove unreferenced "statusbarpanel-text" class;
59 bytes, text/x-review-board-request
dao
: review+
Details 
The following bindings don't seem to be used in anywhere other than tests:

- statusbarpanel-menu-iconic
https://dxr.mozilla.org/mozilla-central/search?q=statusbarpanel-menu-iconic&redirect=true

- statusbarpanel-iconic
https://dxr.mozilla.org/mozilla-central/search?q=statusbarpanel-iconic

- statusbarpanel-iconic-text
https://dxr.mozilla.org/mozilla-central/search?q=statusbarpanel-iconic-text

We may even be able to remove <statusbar> and <statusbarpanel> eventually, as the only consumer seems to be view source in a window, but for now we can start by tackling these unused bindings
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Hmm, Thunderbird and SeaMonkey are using these :|
Depends on: 1417198
Comment on attachment 8927486 [details]
Bug 1416368 - Remove unused statusbarpanel-* bindings;

https://reviewboard.mozilla.org/r/198802/#review204818
Attachment #8927486 - Flags: review?(dao+bmo) → review+
Comment on attachment 8927487 [details]
Bug 1416368 - Remove unreferenced "statusbarpanel-text" class;

https://reviewboard.mozilla.org/r/198804/#review204820
Attachment #8927487 - Flags: review?(dao+bmo) → review+
Depends on: 1418094
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e0ea0c63d14
Remove unused statusbarpanel-* bindings;r=dao
https://hg.mozilla.org/integration/autoland/rev/0c859e821200
Remove unreferenced "statusbarpanel-text" class;r=dao
https://hg.mozilla.org/mozilla-central/rev/2e0ea0c63d14
https://hg.mozilla.org/mozilla-central/rev/0c859e821200
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.