141639 - templatize template parameters in header.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Bug 140435 templatizes the "template parameters" (parameters containing a crude
form of templates by which installations have been able to customize their look
and feel in previous versions of Bugzilla) for footer.html.tmpl.  If it's
necessary for footer.html.tmpl, then it's also necessary for header.html.tmpl.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: templatizes template parameters for header.html.tmpl

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 81961 [details] [diff] [review]
patch v1: templatizes template parameters for header.html.tmpl

>Index: template/en/default/global/banner.html.tmpl
>===================================================================
<...>
>+<center>
>+	<font size="-1">Bugzilla version [% Param('version') %]</font>
>+</center>

Can we use <small> there instead of <font size="-1"> ?	Other than that,
r=caillon.

Comment 3

[Bradley Baetz (:bbaetz)]

This has been done on the patch in bug 140435, though, although gerv didn't
split the banner out to a separate template - I don't think thats needed, since
its probably the first thing to be customised on an installation.

Comment 4

[Matthew Tuck [:CodeMachine]]

I would like to see banner being a separate template.  It would be rare someone
would want to customise header other than the banner part, so I'd rather they
don't need to update when we update the header template.

Comment 5

[Gervase Markham [:gerv]]

Yeah, this is happening over in bug 140435. The latest patch has commandmenu as
a separate template, but not banner; if you want that split out, comment in that
bug. I don't think it's actually the right thing to do - but we can discuss that
over in bug 140435. :-)

Gerv

Comment 6

[Dave Miller [:justdave]]

Do I understand correctly here that the patch on this bug conflicts with the one
on bug 140435?

Comment 7

[Bradley Baetz (:bbaetz)]

It conflicts/is redundant/etc.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Making this bug depend on bug 140435.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Removing dependency.  How does the patch on 140435 templatize the header
parameters?  As far as I can tell it doesn't touch them.  Also, yes, bannerhtml
should be a separate template to minimize forking when it gets customized.

Comment 10

[Gervase Markham [:gerv]]

Yeah, there's been a bit of confusion here. header.html.tmpl got done over in
bug 140993; the redundant params are being removed (and archived) over in bug
140437.

The banner is currently not a separate template; if you think this should be
done, we should probably file a separate bug rather than morph this one. But,
frankly, I don't think it's worth it - I doubt anyone will customise _just_ the
banner, and if they are customising anything else, they need to edit
header.html.tmpl anyway.

I think that we need to accept that people's header.html.tmpl and
footer.html.tmpl are going to be heavily munged, and there's not much we can do
to make their updating life easier, apart from not break the interfaces.

Myk or Dave - I'll leave it to you to either morph or close this bug.

Gerv

Comment 11

[Myk Melez [:myk] [@mykmelez]]

>The banner is currently not a separate template;

That's a regression from the check-in of bug 140993.

>if you think this should be
>done, we should probably file a separate bug rather than morph this one.
>But, frankly, I don't think it's worth it - I doubt anyone will customise _just_
>the banner, and if they are customising anything else, they need to edit
>header.html.tmpl anyway.

The banner is the only mozilla.org-specific part of header.html.tmpl, so there's
good reason to believe installations will customize it first and only.

Closing this bug nevertheless since that's a different bug, and the work in this
bug has been duplicated in bug 140993.