1416456 - js/src/gc/Verifier.cpp: error: ‘DumpObject’ was not declared in this scope

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Christian Holler (:decoder)]

Non-debug builds with --enable-gczeal are broken because DumpObject is DEBUG only. Patch coming up.

Comment 1

[Christian Holler (:decoder)]

Attachment: Bug 1416456 - Fix --enable-gczeal build bustage in JS engine.

Review commit: https://reviewboard.mozilla.org/r/198860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198860/

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8927558 [details]
Bug 1416456 - Fix --enable-gczeal build bustage in JS engine.

https://reviewboard.mozilla.org/r/198860/#review204080

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Christian Holler (:decoder) from comment #0)
Thanks for fixing this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4c15a88c937
Fix --enable-gczeal build bustage in JS engine. r=jandem

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f4c15a88c937

Comment 7

[Julien Cristau [:jcristau]]

Do you want this in 58?

Comment 8

[Christian Holler (:decoder)]

(In reply to Julien Cristau [:jcristau] from comment #7)
> Do you want this in 58?

Yes, it would be useful to have this uplifted because it unbreaks a certain build type required for testing.