Closed Bug 1416456 Opened 2 years ago Closed 2 years ago

js/src/gc/Verifier.cpp: error: ‘DumpObject’ was not declared in this scope

Categories

(Core :: JavaScript Engine, defect, P1, critical)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

Details

Attachments

(1 file)

Non-debug builds with --enable-gczeal are broken because DumpObject is DEBUG only. Patch coming up.
Comment on attachment 8927558 [details]
Bug 1416456 - Fix --enable-gczeal build bustage in JS engine.

https://reviewboard.mozilla.org/r/198860/#review204080
Attachment #8927558 - Flags: review?(jdemooij) → review+
(In reply to Christian Holler (:decoder) from comment #0)
Thanks for fixing this.
Priority: -- → P1
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4c15a88c937
Fix --enable-gczeal build bustage in JS engine. r=jandem
https://hg.mozilla.org/mozilla-central/rev/f4c15a88c937
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Do you want this in 58?
Flags: needinfo?(choller)
(In reply to Julien Cristau [:jcristau] from comment #7)
> Do you want this in 58?

Yes, it would be useful to have this uplifted because it unbreaks a certain build type required for testing.
Flags: needinfo?(choller)
You need to log in before you can comment on or make changes to this bug.