1416466 - Wait for the next event tick before resolving Promise for onload event in tests in security/manager/ssl/tests/mochitest/browser/, for bug 1193394

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a256f95712e8844d888ec18891822e949bc85c6d&selectedJob=143961944
> FAIL | security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js | Actual and expected hostname and port should be equal - "" == "Test Hostname:123" 

those failure in security/manager/ssl/tests/mochitest/browser/ comes from the issue that onload event listener resolves the promise too early.
the test expects all things related to the load event is performed before the promise resolution handler gets called.
so, it should wait for the next event tick before resolving the promise.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Wait for the next event tick before resolving Promise for onload event in tests in security/manager/ssl/tests/mochitest/browser/.

delayed the promise resolution for load event to make sure the page really gets loaded.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c69914a66203
Wait for the next event tick before resolving Promise for onload event in tests in security/manager/ssl/tests/mochitest/browser/. r=mossop

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c69914a662039fc3e359f74ed1c9ba58fcef6306
Bug 1416466 - Wait for the next event tick before resolving Promise for onload event in tests in security/manager/ssl/tests/mochitest/browser/. r=mossop

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c69914a66203