Remove the "control-item" binding and copy the only property ("value") onto its 3 extended bindings

RESOLVED FIXED in Firefox 59

Status

()

P5
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bgrins, Assigned: 86ecce74)

Tracking

(Blocks: 1 bug)

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

(Whiteboard: [xbl-flatten-inheritance][xbl-available])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
There's a binding "control-item" that defines a single property ("value") that maps back to an attribute. This can be copied into the 3 bindings that extend it and the binding can be removed.

https://dxr.mozilla.org/mozilla-central/rev/2535bad09d720e71a982f3f70dd6925f66ab8ec7/toolkit/content/widgets/general.xml#60-65

Inherited bindings (https://dxr.mozilla.org/mozilla-central/search?q=extends+control-item&redirect=false):
- menuitem-base
- radio
- tab
(Reporter)

Updated

a year ago
Whiteboard: [xbl-flatten-inheritance] → [xbl-flatten-inheritance][xbl-available]
(Assignee)

Comment 1

a year ago
Created attachment 8929718 [details] [diff] [review]
Flattened inheritance hierarchy by removing contol-item.

Copied property "value" to menuitem-base, radio, and tab; set their base to be basetext and removed control-item.
Attachment #8929718 - Flags: review?(enndeakin)
(Reporter)

Updated

a year ago
Assignee: nobody → 86ecce74
Status: NEW → ASSIGNED

Updated

a year ago
Attachment #8929718 - Flags: review?(enndeakin) → review+
(Reporter)

Comment 3

a year ago
Could you update the commit message on your patch to include the bug number and the reviewer, as per https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#Commit_Message_Conventions? Something like:

Bug 1416483 - Remove control-item binding and copy the value property onto its children; r=enndeakin

You can then reupload it with an r+ since it's already gotten the review
Flags: needinfo?(86ecce74)
(Assignee)

Comment 4

a year ago
Created attachment 8930581 [details] [diff] [review]
inheritance.patch
Attachment #8929718 - Attachment is obsolete: true
Flags: needinfo?(86ecce74)
Attachment #8930581 - Flags: review+
(Reporter)

Comment 5

a year ago
Try push looks good, marking for checkin
Keywords: checkin-needed
(Reporter)

Comment 6

a year ago
86ecce74, thanks for helping with these! There are a couple more similar bugs available if you are interested in taking them: https://mzl.la/2AyTxCG

Comment 7

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c44cbc57220
Remove control-item binding and copy the value property onto its children. r=enndeakin
Keywords: checkin-needed

Updated

a year ago
status-firefox57: --- → wontfix
status-firefox58: --- → wontfix
status-firefox59: --- → fix-optional
Priority: -- → P5

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c44cbc57220
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.