1416503 - Add RTL to the Saved Addresses and Saved Credit Cards dialogs

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Itiel]

Current implementations of the Saved Addresses and Saved Credit Cards dialogs in the Options tab are missing RTL support.

See attached exmaples for how it currently looks on RTL.

Comment 1

[Itiel]

Attachment: Saved Addresses add

Comment 2

[Itiel]

Attachment: Saved Addresses main

Comment 3

[Itiel]

Attachment: Saved Credit Cards add

Comment 4

[Itiel]

Attachment: Saved Credit Cards main

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Scott, can you look in to this?

Comment 6

[Scott Wu [:scottwu]]

Thanks Jared. I think I know what the cause is.

Comment 7

[Scott Wu [:scottwu]]

Attachment: Bug 1416503 - Add RTL support for Form Autofill preference dialogs.

Review commit: https://reviewboard.mozilla.org/r/210896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210896/

Comment 8

[Scott Wu [:scottwu]]

It appears that the RTL rule is set by each locale in `intl.css`, with style rules like this: https://hg.mozilla.org/l10n-central/fa/file/tip/toolkit/chrome/global/intl.css#l23

However Form Autofill subdialogs load XHTML files rather than XUL, so the direction rule does not apply to them. I think a simple way to get around this is to manually apply the parent element's direction attribute to the subdialog documents. Wonder what your thoughts are with this approach?

Thanks!

Comment 9

[Matthew N. [:MattN]]

Try using the &locale.dir; entity:
https://dxr.mozilla.org/mozilla-central/search?q=locale.dir
<!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd">
   %globalDTD;
https://dxr.mozilla.org/mozilla-central/source/dom/locales/en-US/chrome/global.dtd#5

Comment 10

[Scott Wu [:scottwu]]

Comment on attachment 8940657 [details]
Bug 1416503 - Add RTL support for Form Autofill preference dialogs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210896/diff/1-2/

Comment 11

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8940657 [details]
Bug 1416503 - Add RTL support for Form Autofill preference dialogs.

https://reviewboard.mozilla.org/r/210896/#review217452

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b110713598d
Add RTL support for Form Autofill preference dialogs. r=lchang

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7b110713598d

Comment 14

[Lauren Fu(Firefox EPM)]

Hi Itiel, we just landed this bug. Can you help to verify if the layout is correct now ? Thank you.

Comment 15

[Itiel]

(In reply to Lauren Fu(Firefox EPM) from comment #14)
> Hi Itiel, we just landed this bug. Can you help to verify if the layout is
> correct now ? Thank you.

There indeed is a change, but some buttons and text (the table's labels) are hidden.
I think that the list of items should also be right aligned, but as I don't have internet access to add items in there, I can't be sure, so I'll check when I get back home.
See attached screenshots.

Comment 16

[Itiel]

Attachment: Saved addresses missing button

Comment 17

[Itiel]

Attachment: Saved credit cards missing text and button

Comment 18

[Itiel]

(In reply to Itiel from comment #15)
> There indeed is a change, but some buttons and text (the table's labels) are
> hidden.
> I think that the list of items should also be right aligned, but as I don't
> have internet access to add items in there, I can't be sure, so I'll check
> when I get back home.
> See attached screenshots.

So the items list is indeed RTL, but the blue dotted outline (which shouldn't be there at all I guess, if no items are present), is still LTR.

Lauren, should we reopen here?

Comment 19

[Matthew N. [:MattN]]

No, please file new bugs for issues which aren't already filed. We generally only re-open a FIXED bug if the code gets backed out but since it seems like the change made some improvements and didn't cause major regressions, follow-up bugs would be better.

Comment 20

[Lauren Fu(Firefox EPM)]

Hi Itiel can you help to file this bug again and I will ni Scott in the new bug. Thank you.

Comment 21

[Scott Wu [:scottwu]]

Thanks Itiel, I'm looking into it. It doesn't seem to affect Mac and Linux, and on Windows it looks fine on en-US too. If HE has problems with it other locales might too.

Comment 22

[Scott Wu [:scottwu]]

The blue dotted line issue has been file under Bug 1390674.

Comment 23

[Itiel]

(In reply to Matthew N. [:MattN] (PM if requests are blocking you) from comment #19)
> No, please file new bugs for issues which aren't already filed. We generally
> only re-open a FIXED bug if the code gets backed out but since it seems like
> the change made some improvements and didn't cause major regressions,
> follow-up bugs would be better.

(In reply to Lauren Fu(Firefox EPM) from comment #20)
> Hi Itiel can you help to file this bug again and I will ni Scott in the new
> bug. Thank you.

Done. Thanks!