1416543 - gfx/layers/wr/WebRenderBridgeParent.cpp:108:3: error: 'profiler_register_thread' was not declared in this scope

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Jan Beich]

On Tier3 platforms without GeckoProfiler (iOS, Linux non-x86, BSDs, Solaris) the build is broken because "GeckoProfiler.h" doesn't define profiler_{,un}register_thread[1]. To reproduce on Tier1 platforms before bug 1371159 is fixed one has to force `return None` in gecko_profiler()[2].

$ ./mach bootstrap
$ ./mach build
[...]
In file included from objdir/gfx/layers/Unified_cpp_gfx_layers11.cpp:2:
gfx/layers/wr/WebRenderBridgeParent.cpp:108:3: error: use of undeclared identifier
      'profiler_register_thread'
  profiler_register_thread(name, &stackTop);
  ^
gfx/layers/wr/WebRenderBridgeParent.cpp:114:3: error: use of undeclared identifier
      'profiler_unregister_thread'; did you mean 'gecko_profiler_unregister_thread'?
  profiler_unregister_thread();
  ^~~~~~~~~~~~~~~~~~~~~~~~~~
  gecko_profiler_unregister_thread
gfx/layers/wr/WebRenderBridgeParent.cpp:112:1: note: 'gecko_profiler_unregister_thread'
      declared here
gecko_profiler_unregister_thread()
^
2 errors generated.

[1] https://searchfox.org/mozilla-central/rev/7fb4cc447c06/tools/profiler/public/GeckoProfiler.h#205
[2] http://searchfox.org/mozilla-central/rev/7fb4cc447c06/toolkit/moz.configure#26

Comment 1

[Jan Beich]

Did you mean to use PROFILER_{,UN}REGISTER_THREAD instead per bug 1403868?

Comment 2

[Jan Beich]

$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig # mimic MOZ_AUTOMATION
$ ./mach build
[...]
In file included from objdir/gfx/layers/Unified_cpp_gfx_layers11.cpp:2:
gfx/layers/wr/WebRenderBridgeParent.cpp:107:8: error: unused variable 'stackTop'
      [-Werror,-Wunused-variable]
  char stackTop;
       ^
1 error generated.

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Sorry, I will fix this soon.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: use the gecko profiler macro instead of the real function.

MozReview-Commit-ID: 3ueSAuNCbGp

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/046d8bdbc023
use the gecko profiler macro to register/unregister the thread name. r=me

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

It's just a trivial fix, so I just push it to inbound.

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/046d8bdbc023