Update Readability.js from git (commit c3ff1a2d2c94c1db257b2c9aa88a4b8fbeb221c5 )

RESOLVED FIXED in Firefox 58

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

All these changes have been reviewed on github and/or are followup-fixes. This includes:

- removing commented-out/dead multipage support. We have this in (2...) VCS systems, but it's never been turned on, so removing it seems helpful to code readability and not doing useless work. ( https://github.com/mozilla/readability/commit/c3ff1a2d2c94c1db257b2c9aa88a4b8fbeb221c5#diff-06d8d22df421dacde90a2268083424ab )
- allowing the word limit parameter to be configurable ( https://github.com/mozilla/readability/commit/b3fde168cb7eb42bfc1bd6caedd95e4b53290515#diff-06d8d22df421dacde90a2268083424ab ). We may want this feature to help reduce the number of times people run into the dreaded "Failed to load article from page" errors (e.g. bug 1401087).
- removing presentational table markup (bgcolor etc.) to ensure reasonable display when rendered in Firefox's reader mode. ( https://github.com/mozilla/readability/commit/b7c32feb2548260585d3fc9dd3a67ca7400eb1bc#diff-06d8d22df421dacde90a2268083424ab )
- some minor eslint-related refactoring work ( https://github.com/mozilla/readability/commit/c387d12bc4b0d4e93e83c5e49c6c00a35bfc955a#diff-06d8d22df421dacde90a2268083424ab )

This will implicitly fix bug 1378693 by reverting the change from bug 1355056.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fb001f811d1
update readability from git ( c3ff1a2d2c94c1db257b2c9aa88a4b8fbeb221c5 ), r=already-reviewed
https://hg.mozilla.org/mozilla-central/rev/7fb001f811d1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.