Logging.cpp includes Sprintf.h twice but doesn't include Printf.h

RESOLVED FIXED in Firefox 59

Status

()

defect
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

xpcom/base/Logging.cpp #includes "mozilla/Sprintf.h" twice, but doesn't #include "mozilla/Printf.h". This causes the uses of Printf to not compile in release non-unified builds in gecko-media.

Logging.cpp should #include "mozila/Printf.h".
Comment on attachment 8927684 [details]
Bug 1416597 - Include Printf.h in Logging.cpp.

https://reviewboard.mozilla.org/r/198966/#review203972
Attachment #8927684 - Flags: review?(nfroyd) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf6e51eb9bae
Include Printf.h in Logging.cpp. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/cf6e51eb9bae
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.