1416620 - regression: BMO's buttons don't change when hovering over them (Episode 2)

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Nightly 58 x64 20171112100435 de_DE aabfc14671b55983e1c3053989a4c3b7c5691aaa @ Debian Testing (KDE, Radeon RX480)
fresh profile: layers.acceleration.force-enabled, gfx.webrender.enabled

* This only happens with WebRender.
* bug 1414036 had been fixed two weeks ago.

STR (what I did with mozregression):
1. open https://bugzilla.mozilla.org/show_bug.cgi?id=1390741
2. hover the grey "▾" button on the top right of bugzilla (or "Show Obsolete Attachments")
3. They should get darker when hovering them, but they don't

mozregression --good 2017-11-04 --bad 2017-11-13 --profile-persistence clone-first
> 7:07.72 INFO: Last good revision: 8e788d9983b80c7cf6ed021f1536dd8a97941674
> 7:07.72 INFO: First bad revision: aabfc14671b55983e1c3053989a4c3b7c5691aaa
> 7:07.72 INFO: Pushlog:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8e788d9983b80c7cf6ed021f1536dd8a97941674&tochange=aabfc14671b55983e1c3053989a4c3b7c5691aaa

Comment 1

[Darkspirit]

Test URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1390741

mozregression --good 2017-11-04 --bad 2017-11-13 --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true"
> [...]
> 6:01.76 INFO: Last good revision: 8e788d9983b80c7cf6ed021f1536dd8a97941674
> 6:01.76 INFO: First bad revision: 58b6b371c2f85614ab52dc2d6235e12af020dc1f
> 6:01.76 INFO: Pushlog:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8e788d9983b80c7cf6ed021f1536dd8a97941674&tochange=58b6b371c2f85614ab52dc2d6235e12af020dc1f
> 
> 6:03.41 INFO: ************* Switching to autoland
> [...]
> 8:32.87 INFO: Last good revision: 7d77ff1bbdc451d566ea9e011976d9ae89200d74
> 8:32.87 INFO: First bad revision: 75381304ee9a3c3c8787192ab3704db0a5be9f37
> 8:32.87 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7d77ff1bbdc451d566ea9e011976d9ae89200d74&tochange=75381304ee9a3c3c8787192ab3704db0a5be9f37

> Ethan Lin — Bug 1415989 - Do not use 'ShouldUseAdvancedLayer' for button type display items. r=jrmuizel

Comment 2

[Ethan Lin[:ethlin]]

I think we need a testcase for this.

Comment 3

[Ethan Lin[:ethlin]]

Attachment: Bug 1416620 - Part1. Fix webrender commands in nsDisplayButtonBorder.

Review commit: https://reviewboard.mozilla.org/r/198992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198992/

Comment 4

[Ethan Lin[:ethlin]]

Attachment: Bug 1416620 - Part2. Add a reftest for button border with inset shadow and empty border.

Review commit: https://reviewboard.mozilla.org/r/198994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198994/

Comment 5

[Ethan Lin[:ethlin]]

Comment on attachment 8927721 [details]
Bug 1416620 - Part2. Add a reftest for button border with inset shadow and empty border.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198994/diff/1-2/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8927720 [details]
Bug 1416620 - Part1. Fix webrender commands in nsDisplayButtonBorder.

https://reviewboard.mozilla.org/r/198992/#review204110

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8927721 [details]
Bug 1416620 - Part2. Add a reftest for button border with inset shadow and empty border.

https://reviewboard.mozilla.org/r/198994/#review204112

Thanks for adding a test!

Comment 8

[Ethan Lin[:ethlin]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd7463a84ea2d5ed0085540252af6305bd669628

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48580e1f535
Part1. Fix webrender commands in nsDisplayButtonBorder. r=kats
https://hg.mozilla.org/integration/autoland/rev/3b45218edc2e
Part2. Add a reftest for button border with inset shadow and empty border. r=kats

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c48580e1f535
https://hg.mozilla.org/mozilla-central/rev/3b45218edc2e

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/5b7ac4b432c1
Backed out 2 changesets for failing own reftest. r=backout a=backout on a CLOSED TREE

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing own reftest on Android:

https://hg.mozilla.org/mozilla-central/rev/5b7ac4b432c10fe564efbb53e9d67a39093753a8

Push with failures: https://hg.mozilla.org/mozilla-central/rev/5b7ac4b432c10fe564efbb53e9d67a39093753a8

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This also causes layout/reftests/css-invalid/select/select-disabled-fieldset-1.html to fail on Android:

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=854a8759f85545fc5b4f4ac0bf55f9291743d778&filter-searchStr=9b9087d7dc4cea40dd95c345767555bcd82eaed7&tochange=b69589aa70895d84e2c889e482043b6ae16f2f62

Comment 14

[Ethan Lin[:ethlin]]

I think the new reftest changes the some chunk's tests, so we have different combinations. I'm not sure how to fix the android failure. I will land the part1 first.

try push with part1: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e01d90dec93a5dcdb1648fca86a372ec87c0105&selectedJob=145254140

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa0d3bfe9164
Fix webrender commands in nsDisplayButtonBorder. r=kats

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/aa0d3bfe9164

Comment 17

[Darkspirit]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #0)
> Nightly 58 x64 20171112100435 de_DE aabfc14671b55983e1c3053989a4c3b7c5691aaa @ Debian Testing (KDE, Radeon RX480)
> fresh profile: layers.acceleration.force-enabled, gfx.webrender.enabled

Verified fixed in
Nightly 59 x64 20171118100420 de_DE d4753dc14b2ab9c42123b6d60a68106df40f45cd @ Debian Testing (KDE, Radeon RX480). Thank you!