Closed Bug 1416657 Opened 3 years ago Closed 1 year ago

Tedious warning for test_cookies_async_failure.js

Categories

(Core :: Networking: Cookies, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: junior, Assigned: baku)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

while I execute test for |mach xpcshell-test extensions/cookie/test/unit/test_cookies_async_failure.js|, 3000 warnings appear:

PROCESS_OUTPUT: Thread-1 (pid:53940) "[53940, Main Thread] WARNING: NS_ENSURE_TRUE(aChannel) failed: file /Users/juhsu/mozilla-central/dom/base/ThirdPartyUtil.cpp, line 186"

indicating this
https://searchfox.org/mozilla-central/rev/fe75164c55321e011d9d13b6d05c1e00d0a640be/dom/base/ThirdPartyUtil.cpp#186

Not sure if the warning is valid.
Assignee: nobody → amarchesini
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c47dd1562f8
Avoid calling IsThirdPartyChannel() with a nullptr channel in nsCookieService, r=Ehsan
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.