1416688 - error: ‘profiler_register_thread’ was not declared in this scope

Status: RESOLVED DUPLICATE of bug 1416543

(Core :: Graphics: WebRender, defect)

Description

[Dan Horák]

Our CI shows that a change that went in in the last 2 days broke build on aarch64 and s390x platforms, ppc64/ppc64le would be likely affected as well, but are currently blocked by #1416170.

...
/usr/bin/g++ -std=gnu++11 -o Unified_cpp_gfx_layers11.o -c -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/dist/stl_wrappers -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/dist/system_wrappers -include /home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/layers -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/gfx/layers -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/ipc/ipdl/_ipdlheaders -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/ipc/chromium/src -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/ipc/glue -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/docshell/base -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/layout/base -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/layout/generic -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/media/libyuv/libyuv/include -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/skia -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/skia/skia/include/config -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/skia/skia/include/core -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/skia/skia/include/gpu -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/skia/skia/include/utils -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/dist/include -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/dist/include/nspr -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/mozilla-config.h -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wc++1z-compat -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fno-omit-frame-pointer -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/dist/include/cairo -I/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/widget/gtk/compat-gtk3 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0/unix-print -pthread -Wno-error=shadow -Wno-maybe-uninitialized  -MD -MP -MF .deps/Unified_cpp_gfx_layers11.o.pp  -fdiagnostics-color  /home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/gfx/layers/Unified_cpp_gfx_layers11.cpp
In file included from /home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/obj-s390x-ibm-linux-gnu/gfx/layers/Unified_cpp_gfx_layers11.cpp:2:0:
/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/layers/wr/WebRenderBridgeParent.cpp: In function ‘void gecko_profiler_register_thread(const char*)’:
/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/layers/wr/WebRenderBridgeParent.cpp:108:3: error: ‘profiler_register_thread’ was not declared in this scope
   profiler_register_thread(name, &stackTop);
   ^~~~~~~~~~~~~~~~~~~~~~~~
/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/layers/wr/WebRenderBridgeParent.cpp:108:3: note: suggested alternative: ‘gecko_profiler_register_thread’
   profiler_register_thread(name, &stackTop);
   ^~~~~~~~~~~~~~~~~~~~~~~~
   gecko_profiler_register_thread
/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/layers/wr/WebRenderBridgeParent.cpp: In function ‘void gecko_profiler_unregister_thread()’:
/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/layers/wr/WebRenderBridgeParent.cpp:114:3: error: ‘profiler_unregister_thread’ was not declared in this scope
   profiler_unregister_thread();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/gfx/layers/wr/WebRenderBridgeParent.cpp:114:3: note: suggested alternative: ‘gecko_profiler_unregister_thread’
   profiler_unregister_thread();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~
   gecko_profiler_unregister_thread
gmake[4]: *** [/home/jenkins/workspace/Firefox-default/label/s390x/firefox-src/config/rules.mk:1030: Unified_cpp_gfx_layers11.o] Error 1

Comment 1

[Sotaro Ikeda [:sotaro]]

It seems like dup of Bug 1416543.

Comment 2

[Dan Horák]

Let me check, but you are most likely right ...

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Yes, I think the Bug 1416543 could fix this issue. Please try again.