Closed
Bug 1416743
Opened 6 years ago
Closed 6 years ago
llvm-cov is not available on test machines
Categories
(Testing :: Code Coverage, defect)
Testing
Code Coverage
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(2 files)
1.11 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
1.55 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
grcov can't run on test machines because 'llvm-cov' is missing. There are two options: 1) Use the LLVM API in grcov to avoid the dependency on the llvm-cov binary; 2) Package 'llvm-cov' and its dependencies and install it on test machines. I'm working on option 1 for now. Note, for some reason the test harness is not able to notice that grcov is failing but it's hanging while waiting for grcov to finish. I suppose it could be a problem related to the Python subprocess module.
Assignee | ||
Comment 1•6 years ago
|
||
grcov 0.1.29 can parse LLVM gcov data without the need of the external llvm-cov binary.
Attachment #8928338 -
Flags: review?(jmaher)
Assignee | ||
Comment 2•6 years ago
|
||
grcov needs to know that the gcda files were generated by llvm, so we have to pass the "--llvm" argument.
Attachment #8928339 -
Flags: review?(jmaher)
Updated•6 years ago
|
Attachment #8928338 -
Flags: review?(jmaher) → review+
Updated•6 years ago
|
Attachment #8928339 -
Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/61a5cc672896 Update grcov to version 0.1.29, bundling VC++ redistributable libraries. r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/20f9784628e9 Pass '--llvm' argument to grcov on Windows. r=jmaher
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/61a5cc672896 https://hg.mozilla.org/mozilla-central/rev/20f9784628e9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•