Closed Bug 1416756 Opened 7 years ago Closed 7 years ago

mingw32 builds broken by patch for bug 1408308

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: aryx, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1416756: Stub out Servo_SourceSizeList_Drop so MingGW builds again.
59 bytes, text/x-review-board-request
heycam
: review+
Details
https://treeherder.mozilla.org/logviewer.html#?job_id=144279526&repo=autoland Tom, can get this on track for a fix? Thank you. [task 2017-11-13T13:34:59.075Z] 13:34:59 INFO - INPUT("../../modules/freetype2/winfnt.o") [task 2017-11-13T13:34:59.075Z] 13:34:59 INFO - INPUT("StaticXULComponentsEnd/StaticXULComponentsEnd.o") [task 2017-11-13T13:34:59.076Z] 13:34:59 INFO - ../../dom/base/Unified_cpp_dom_base2.o: In function `ZNK7mozilla13DefaultDeleteI22RawServoSourceSizeListEclEPS1_': [task 2017-11-13T13:34:59.076Z] 13:34:59 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/ServoBindingTypes.h:232: undefined reference to `Servo_SourceSizeList_Drop' [task 2017-11-13T13:34:59.076Z] 13:34:59 INFO - collect2: error: ld returned 1 exit status [task 2017-11-13T13:34:59.092Z] 13:34:59 INFO - gmake[4]: *** [xul.dll] Error 1 [task 2017-11-13T13:34:59.092Z] 13:34:59 INFO - gmake[4]: Leaving directory `/builds/worker/workspace/build/src/obj-firefox/toolkit/library' [task 2017-11-13T13:34:59.092Z] 13:34:59 INFO - gmake[3]: *** [toolkit/library/target] Error 2 [task 2017-11-13T13:34:59.093Z] 13:34:59 INFO - gmake[3]: Leaving directory `/builds/worker/workspace/build/src/obj-firefox' [task 2017-11-13T13:34:59.093Z] 13:34:59 INFO - gmake[2]: *** [compile] Error 2 [task 2017-11-13T13:34:59.093Z] 13:34:59 INFO - gmake[2]: Leaving directory `/builds/worker/workspace/build/src/obj-firefox' [task 2017-11-13T13:34:59.093Z] 13:34:59 INFO - gmake[1]: *** [default] Error 2 [task 2017-11-13T13:34:59.093Z] 13:34:59 INFO - gmake[1]: Leaving directory `/builds/worker/workspace/build/src/obj-firefox' [task 2017-11-13T13:34:59.094Z] 13:34:59 INFO - gmake: *** [build] Error 2
Flags: needinfo?(tom)
:emilio said he was going to figure this out in Comment 12 on Bug 1408308. The MinGW build disables Stylo, so I suspect that the patch does not work with --disable-stylo and that's the root of the problem.
Assignee: nobody → emilio
Flags: needinfo?(tom) → needinfo?(emilio)
Yeah, so I wasn't completely sure it was the reason, thanks for confirming. I'll just stub the Drop function. Weird that android doesn't fail to build too.
Flags: needinfo?(emilio)
Oh I guess we build stylo on android too now...
Attachment #8927854 - Flags: review?(tom) → review?(manishearth)
I'm afraid I don't have any context into this code, so any review I gave wouldn't really be worth much. (Also I don't have sufficient permission for autoland to land my r+ so you'd need another reviewer anyway.)
Priority: -- → P3
Comment on attachment 8927854 [details] Bug 1416756: Stub out Servo_SourceSizeList_Drop so MingGW builds again. https://reviewboard.mozilla.org/r/199138/#review204328
Attachment #8927854 - Flags: review+
Attachment #8927854 - Flags: review?(manishearth)
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fbe652b8ecf7 Stub out Servo_SourceSizeList_Drop so MingGW builds again. r=heycam
Blocks: 1416964
Pushed by ccoroiu@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/9673bed1d07e Stub out Servo_SourceSizeList_Drop so MingGW builds again. r=heycam a=mingw32-fix
https://hg.mozilla.org/mozilla-central/rev/9673bed1d07e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: