1416820 - Add a close tab button from phone browser tab

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, enhancement, P2)

Description

[James Hugman [:jhugman] [@jhugman]]

Either a "close tab" in the Tab Tray long press menu, or the page action menu.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: 2017-11-17 17.10.46.png

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: 2017-11-17 17.10.38.png

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3476

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Merged in to master.

Uplifted to v10.x 1076610

Comment 5

[Isabel Rios[:isabel_rios]]

I was looking at these Close Tab options, nice to have them! but was wondering if when we are on TopSites and there is not any tab open, when we long press on the tabs button to get the menu if it would make sense to have that Close Tab disabled. Currently you can tap on it, nothing happens since there is not any tab to close, so kind of not confusing but polishing...wdyt?
Thanks!

Comment 6

[Simon Basca [:SimonB]]

Verifying as fix on 10.3(7934). "Close tab" button has been added on long press on tab counter.

Comment 7

[Simon Basca [:SimonB]]

The "Close tab" button has also been added to the Page Action menu.

Comment 8

[James Hugman [:jhugman] [@jhugman]]

> if when we are on TopSites and there is not any tab open, when we long press on the tabs button to get the menu if it would make sense to have that Close Tab disabled. Currently you can tap on it, nothing happens since there is not any tab to close, so kind of not confusing but polishing...wdyt?

This when a) you're on your new tab screen b) there's only one tab open. 

IIUIC I'm not very concerned about this. It's a corner case, which is relatively hard to implement. Good catch though!

Comment 9

[Isabel Rios[:isabel_rios]]

Bug closed, removing ni? requested