1416897 - Add tests for crossref.rs

Status: RESOLVED WORKSFORME

(Webtools :: Searchfox, enhancement)

Description

[Andrew McCreight [:mccr8]]

It would be good if there was a script that could be run to do some basic tests. The simplest approach would be to check the output of the three files from this script when run on the test repo.

My initial patch for bug 1415700 had a bug that would not have been caught by this, however. For some reason when running on the Gecko repo we hit the "Unable to open source file" case, because it tries to analyze certain files that look like they are the output of config. My first patch was returning from main() rather than continuing. This would cause the Firefox repo to only be partially scanned.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

We generally have test coverage for crossref.rs now through the test_check_insta mechanism documented at https://github.com/mozsearch/mozsearch/blob/master/docs/testing-checks.md against both the tests repo and the production checks against mozilla-central. In particular, the checks exercise router.py's use of the identifiers file and the crossref file and now we also have rust-backed checks for the tests repo for both.

For the specific case of partial processing we might consider adding a sentinel last file to be processed and then adding a production check for that corresponding symbol to be resolved through identifiers and crossref.