1416946 - StrictMode violation: SearchEngineManager not closing an input to a local file

Status: RESOLVED DUPLICATE of bug 1428128

(Firefox for Android Graveyard :: General, defect, P3)

Description

[:Grisha Kruglov]

Seeing quite a few of these errors in my emulator's logcat:

11-13 19:30:48.494  4739  4751 E StrictMode: java.lang.Throwable: Explicit termination method 'end' not called
11-13 19:30:48.494  4739  4751 E StrictMode: 	at dalvik.system.CloseGuard.open(CloseGuard.java:223)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at java.util.zip.Inflater.<init>(Inflater.java:106)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.mozglue.NativeZip.createInputStream(NativeZip.java:78)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.mozglue.NativeZip._getInputStream(Native Method)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.mozglue.NativeZip.getInputStream(NativeZip.java:62)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.util.GeckoJarReader.getStream(GeckoJarReader.java:205)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.util.GeckoJarReader.getStream(GeckoJarReader.java:177)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.search.SearchEngineManager.getInputStreamFromSearchPluginsJar(SearchEngineManager.java:718)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.search.SearchEngineManager.createEngineFromLocale(SearchEngineManager.java:578)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.search.SearchEngineManager.createEngineFromName(SearchEngineManager.java:491)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.search.SearchEngineManager.access$400(SearchEngineManager.java:55)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.search.SearchEngineManager$GetDefaultEngineDistributionCallbacks.defaultBehavior(SearchEngineManager.java:290)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.search.SearchEngineManager$GetDefaultEngineDistributionCallbacks.distributionNotFound(SearchEngineManager.java:220)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.distribution.Distribution$4.run(Distribution.java:1098)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at android.os.Handler.handleCallback(Handler.java:789)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at android.os.Handler.dispatchMessage(Handler.java:98)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at android.os.Looper.loop(Looper.java:164)
11-13 19:30:48.494  4739  4751 E StrictMode: 	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:43)

Comment 1

[Jan Henning [:JanH]]

I think this time these strictmode warnings were caused by bug 1428128 - when building via Gradle the omnijar was erroneously stored compressed, so we'd try opening a compressed omni.ja, which doesn't work (see [1] and [2]), and then abort without closing the InflaterInputStream we had opened without really wanting to.

If somebody feels strongly about immediately closing the input stream after such errors, feel free to reopen this.


[1] https://dxr.mozilla.org/mozilla-central/rev/351c75ab74c9a83db5c0662ba271b49479adb1f1/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/GeckoJarReader.java#187-213
[2] https://dxr.mozilla.org/mozilla-central/rev/351c75ab74c9a83db5c0662ba271b49479adb1f1/mobile/android/geckoview/src/main/java/org/mozilla/gecko/mozglue/NativeZip.java#29-32