1416968 - building with --enable-official-branding is broken with: ValueError: Object directory paths are not allowed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Building Firefox with --enable-official-branding currently yields the following error:

> 0:13.24 Reticulating splines...
> 0:25.08 Traceback (most recent call last):
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/configure.py", line 127, in <module>
> 0:25.08     sys.exit(main(sys.argv))
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/configure.py", line 34, in main
> 0:25.08     return config_status(config)
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/configure.py", line 122, in config_status
> 0:25.08     return config_status(args=[], **encode(sanitized_config, encoding))
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/config_status.py", line 150, in config_status
> 0:25.08     the_backend.consume(definitions)
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/backend/base.py", line 128, in consume
> 0:25.08     if (not self.consume_object(obj) and
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/backend/fastermake.py", line 57, in consume_object
> 0:25.08     self._consume_jar_manifest(obj)
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/backend/common.py", line 504, in _consume_jar_manifest
> 0:25.08     (src, output_basename))
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/frontend/context.py", line 551, in __call__
> 0:25.08     return super(PathMeta, cls).__call__(context, value)
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/frontend/context.py", line 662, in __init__
> 0:25.08     super(RenamedSourcePath, self).__init__(context, source)
> 0:25.08   File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/frontend/context.py", line 621, in __init__
> 0:25.08     raise ValueError('Object directory paths are not allowed')
> 0:25.08 ValueError: Object directory paths are not allowed
> 0:25.69 *** Fix above errors and then restart with\
> 0:25.69                "/usr/bin/make -f client.mk build"
> 0:25.69 /home/dbaron/builds/mozilla-central/mozilla/client.mk:246: recipe for target 'configure' failed
> 0:25.69 make[1]: *** [configure] Error 1

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Removing the parenthetical bits at the end of browser/branding/official/content/jar.mn avoids the error.  These were modified recently in bug 1415014.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The path in question is "!../mozicon128.png".

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch?

Comment 4

[Makoto Kato [:m_kato]]

Ah, my mistake.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/611e36cc135a7e6f5749ddb8ec09238bfa8be4d2
Bug 1416968 - Fix path to unbreak --enable-official-branding build.  r=m_kato

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/611e36cc135a

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I filed bug 1417180 on getting a better error message here.