Use Correct Pocket Read More Endpoint

RESOLVED FIXED in Firefox 58

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sdaswani, Assigned: mcomella)

Tracking

Firefox 57
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox58 verified, firefox59 fixed)

Details

Attachments

(1 attachment)

While we are making this change, can we update it to:

https://getpocket.com/explore/trending?src=ff_android&cdn=0
Priority: -- → P1
Matt, currently the URL we're using is:
  https://getpocket.cdn.mozilla.net/explore/trending?src=ff_android

Unlike this URL, the new URL doesn't provide a source (i.e. coming from FF Android) and we don't intentionally send any other indication of where these links could be coming from (i.e. no referrer): is that okay?

fwiw:
- Server-side, we could extract FF for Android from the user agent, but we wouldn't know if it's specifically coming from the MORE button
- Client-side, we have telemetry for how many times the MORE button is clicked
Flags: needinfo?(matt)
Oh, nevermind - the src in comment 0 and comment 1 are different. comment 1 specifies ff_android as the source.
Flags: needinfo?(matt)
Mike - correct - https://getpocket.com/explore/trending?src=ff_android&cdn=0 is what we want to use and that includes the `src`
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/418fcd00bb57
Update Pocket MORE link. r=liuche
Comment on attachment 8932186 [details]
Bug 1416971: Update Pocket MORE link.

Approval Request Comment
[Feature/Bug causing the regression]: Improper initial implementation (via miscommunication?)
[User impact if declined]: Users have the same experience - I'm not sure why Pocket wants the URL change
[Is this code covered by automated tests?]: None
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Likely unnecessary but STR: 1) Open top sites, 2) Click MORE, 3) Verify URL and that trending pocket stories appear. Ideally verify this works in at least en-US and de-DE with the appropriate language, but here's all locales we support [1]

[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple, one line change: we replace the URL value in a constant
[String changes made/needed]: None

[1]: https://searchfox.org/mozilla-central/rev/7a8c667bdd2a4a32746c9862356e199627c0896d/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/ActivityStreamConfiguration.java#32
Attachment #8932186 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/418fcd00bb57
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Comment on attachment 8932186 [details]
Bug 1416971: Update Pocket MORE link.

Update the pocket more link. Beta58+.
Attachment #8932186 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Target Milestone: Firefox 57 → Firefox 59
Verified as fixed on Beta 58.0b9 on Samsung Galaxy Note 4 (Android 5.0.1).
You need to log in before you can comment on or make changes to this bug.