Closed Bug 1416984 Opened 3 years ago Closed 3 years ago

test_ext_cookies.html fails when run locally

Categories

(WebExtensions :: General, defect, P3)

defect

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: psnyde2, Assigned: bsilverberg)

Details

(Whiteboard: [cookies])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171024165158

Steps to reproduce:

./mach test toolkit/components/extensions/test/mochitest/test_ext_cookies.html

From conversations on irc, seems to only happen when run locally, not on testing servers.

This is head as of when im posting this (git commit 4049c95d4d0b)


Actual results:

Buffered messages finished
0 INFO TEST-START | Shutdown
1 INFO Passed:  455
2 INFO Failed:  17
3 INFO Todo:    0
4 INFO Mode:    e10s
5 INFO SimpleTest FINISHED
The following tests failed:
492 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | one cookie found for matching domain - Expected: 2, Actual: 1 
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:77:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
493 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for name is correct - Expected: name1, Actual:  
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:78:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
494 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for value is correct - Expected: value1, Actual:  
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:78:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
495 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for session is correct - Expected: false, Actual: true 
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:78:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
496 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | all expected properties found - Expected: 10, Actual: 9 
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:7:7
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:78:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
497 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | one non-secure cookie found - Expected: 2, Actual: 1 
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:84:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
498 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for name is correct - Expected: name1, Actual:  
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:85:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
499 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for value is correct - Expected: value1, Actual:  
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:85:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
500 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for session is correct - Expected: false, Actual: true 
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:85:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
501 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | all expected properties found - Expected: 10, Actual: 9 
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:7:7
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:85:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
502 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | one cookie found for valid storeId - Expected: 2, Actual: 1 
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:91:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
503 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for name is correct - Expected: name1, Actual:  
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:92:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
504 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for value is correct - Expected: value1, Actual:  
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:92:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
505 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | property value for session is correct - Expected: false, Actual: true 
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:5:9
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:92:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
506 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | all expected properties found - Expected: 10, Actual: 9 
    assertExpected@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:7:7
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:92:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
507 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | one session cookie found - Expected: 2, Actual: 1 
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:137:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
508 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_cookies.html | no non-secure cookies found - Expected: 1, Actual: 0 
    background@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:160:5
    async*@moz-extension://d3f5ce02-c368-2f45-aac5-66575316416d/%7B4de8c6c8-d2e6-5c4a-bb17-45ca94a4adf2%7D.js:1:17
    
Buffered messages finished
SUITE-END | took 14s



Expected results:

No failures
Component: Untriaged → WebExtensions: General
Product: Firefox → Toolkit
I have reproduced this on OS X with the latest m-c. I have found that the error only occurs during the second running of the tests, in non-oop mode. If I run in just oop mode, then the tests pass, and if I run in just non-oop mode the tests also pass. I wonder if the test is not cleaning up after itself properly. I am experimenting with adding some clean-up code.

This doesn't seem like a high priority, but probably something that should be fixed.
Assignee: nobody → bob.silverberg
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: investigate[cookies]
Priority: -- → P3
Whiteboard: investigate[cookies] → [cookies]
Comment on attachment 8928528 [details]
Bug 1416984 - Remove all cookies at the beginning of test_ext_cookies.html,

https://reviewboard.mozilla.org/r/199782/#review204960
Attachment #8928528 - Flags: review?(mixedpuppy) → review+
Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c566123d616
Remove all cookies at the beginning of test_ext_cookies.html, r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/3c566123d616
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(bob.silverberg)
Flags: needinfo?(bob.silverberg) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.