Closed Bug 1416985 Opened 7 years ago Closed 7 years ago

MOZ_SQLITE_COOKIES_OLD_SCHEMA seems bogus for unreasonable many people using cookies.txt

Categories

(Core :: Networking: Cookies, enhancement, P3)

Product:
Core
Component:
Networking: Cookies
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

cookiesTxtProbe, v1
1.71 KB, patch
jdm
: review+
gchang
: approval-mozilla-beta-
Details | Diff | Splinter Review 
telemetry shows we have >2M nightly users with legacy cookies.txt, which much more than ADI of nightly.
Priority: -- → P3
Whiteboard: [necko-triaged]
Ping the telemetry only if we have at least one cookie in cookies.txt
Attachment #8929293 - Flags: review?(josh)
Attachment #8929293 - Flags: review?(josh) → review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5be59846eac0
Fix the telemetry for using legacy cookies.txt, r=jdm
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5be59846eac0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8929293 [details] [diff] [review]
cookiesTxtProbe, v1

Approval Request Comment
[Feature/Bug causing the regression]:Bug 1412218
[User impact if declined]:millions wrong redundant ping to telemetry server a week in nightly
[Is this code covered by automated tests?]:No
[Has the fix been verified in Nightly?]:yes, ping count decreases
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:No
[Is the change risky?]:No
[Why is the change risky/not risky?]:Only telemetry change
[String changes made/needed]:No
Attachment #8929293 - Flags: approval-mozilla-beta?
Comment on attachment 8929293 [details] [diff] [review]
cookiesTxtProbe, v1

There is no user impact here. Beta58-. Let's let it ride the train.
Attachment #8929293 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
(In reply to Gerry Chang [:gchang] from comment #6)
> Comment on attachment 8929293 [details] [diff] [review]
> cookiesTxtProbe, v1
> 
> There is no user impact here. Beta58-. Let's let it ride the train.

Thanks for taking care of this!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: