Closed Bug 1416996 Opened 2 years ago Closed 2 years ago

setup builders to compile suite w/ stylo enabled

Categories

(SeaMonkey :: Release Engineering, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ewong, Assigned: ewong)

References

Details

(Keywords: leave-open, Whiteboard: [stylo])

Attachments

(6 files, 8 obsolete files)

4.88 KB, patch
frg
: review+
Details | Diff | Splinter Review
2.39 KB, patch
frg
: review+
Details | Diff | Splinter Review
1.17 KB, patch
frg
: review+
Details | Diff | Splinter Review
727 bytes, patch
frg
: review+
Details | Diff | Splinter Review
734 bytes, patch
ewong
: review+
Details | Diff | Splinter Review
721 bytes, patch
ewong
: review+
Details | Diff | Splinter Review
At this point, we do not have stylo (and thus webrender) enabled on
all our builds.  This means we don't know what will happen if we
do. 

I'd like to have a set of builders w/ stylo enabled and using
just comm-central.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8928115 - Flags: review?(frgrahl)
Attachment #8928115 - Attachment is obsolete: true
Attachment #8928115 - Flags: review?(frgrahl)
rationale for macosx64's mozconfig.  

We don't do cross-compile and since we don't need the disable stylo,
we might as well just directly use local-mozconfig.common
Attachment #8928365 - Flags: review?(frgrahl)
Attachment #8928368 - Flags: review?(frgrahl)
Comment on attachment 8928365 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs.

> +ac_add_options --enable-webrender

I think this is the default now. Could you check.

r+ with this checked.

Keep in mind that we plan to do cross-compiles. If i find some time I will start with the configs soon. probably Nightly only first.
Attachment #8928365 - Flags: review?(frgrahl) → review+
Comment on attachment 8928368 [details] [diff] [review]
[configs] enable stylo builds for c-c only

> +        if platform in BRANCHES[branch]['platforms']

Missing/accidentally removed : I think.

r+ with nit fixed.
Attachment #8928368 - Flags: review?(frgrahl) → review+
Attached patch [configs] fix nits (obsolete) — Splinter Review
Attachment #8928368 - Attachment is obsolete: true
Attachment #8928827 - Flags: review+
(In reply to Frank-Rainer Grahl (:frg) from comment #4)
> Comment on attachment 8928365 [details] [diff] [review]
> [mozconfigs] nightly-stylo mozconfigs.
> 
> > +ac_add_options --enable-webrender
> 
> I think this is the default now. Could you check.
> 
> r+ with this checked.
> 
> Keep in mind that we plan to do cross-compiles. If i find some time I will
> start with the configs soon. probably Nightly only first.

from https://hg.mozilla.org/mozilla-central/file/tip/toolkit/moz.configure#l850,

I suppose it means it is enabled by default.
since webrender is enabled by default,  no need for --enable-webrender..
(from https://hg.mozilla.org/mozilla-central/file/tip/toolkit/moz.configure#l850)
though I don't see it being disabled (aside from --disable-webrender).
Attachment #8928365 - Attachment is obsolete: true
Attachment #8928847 - Flags: review?(frgrahl)
Comment on attachment 8928847 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs (v2) [checked-in]

r+
Attachment #8928847 - Flags: review?(frgrahl) → review+
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/99accbe79a6d
Re-enable stylo/webrender building in suite using separate stylo mozconfigs. r=frg
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [stylo]
Attachment #8928827 - Attachment is obsolete: true
Attachment #8952622 - Flags: review?(frgrahl)
Attachment #8952622 - Flags: review?(frgrahl)
Just going to do the stylo builds for linux, linux64 and linux-debug only.
We don't have enough osx64 or wiin32 machines to even worth bothering
with stylo builds.
Attachment #8952622 - Attachment is obsolete: true
Attachment #8952643 - Flags: review?(frgrahl)
Comment on attachment 8952643 [details] [diff] [review]
[configs] fixed configs to enable stylo for linux* and linux-debug only [checked-in]

NIT: 2 trailing blanks in comments.

I see only a nightly-stylo in the suite linux32 configs. Do we need a debug-stylo too?

r+ with NITs fixed and question answered.
Attachment #8952643 - Flags: review?(frgrahl) → review+
(In reply to Frank-Rainer Grahl (:frg) from comment #13)
> Comment on attachment 8952643 [details] [diff] [review]
> [configs] fixed configs to enable stylo for linux* and linux-debug only
> 
> NIT: 2 trailing blanks in comments.
> 
> I see only a nightly-stylo in the suite linux32 configs. Do we need a
> debug-stylo too?
> 
> r+ with NITs fixed and question answered.

I'll fix the nit.

As for linux-debug,  it's covered.  

+for plat in PLATFORMS_TO_BUILD_STYLO:
+    if plat.endswith('-debug'):
+        plat_with_stylo = "%s-stylo-%s" % tuple(plat.split("-"))
+    else:
+        plat_with_stylo = '%s-stylo' % plat
+    PLATFORM_VARS[plat_with_stylo] = deepcopy(PLATFORM_VARS[plat])

I'm opting to do a
(In reply to Edmund Wong (:ewong) from comment #14)
> (In reply to Frank-Rainer Grahl (:frg) from comment #13)
> > Comment on attachment 8952643 [details] [diff] [review]
> > [configs] fixed configs to enable stylo for linux* and linux-debug only
> > 
> > NIT: 2 trailing blanks in comments.
> > 
> > I see only a nightly-stylo in the suite linux32 configs. Do we need a
> > debug-stylo too?
> > 
> > r+ with NITs fixed and question answered.
> 
> I'll fix the nit.
> 
> As for linux-debug,  it's covered.  
> 
> +for plat in PLATFORMS_TO_BUILD_STYLO:
> +    if plat.endswith('-debug'):
> +        plat_with_stylo = "%s-stylo-%s" % tuple(plat.split("-"))
> +    else:
> +        plat_with_stylo = '%s-stylo' % plat
> +    PLATFORM_VARS[plat_with_stylo] = deepcopy(PLATFORM_VARS[plat])
> 
> I'm opting to do a

I'm opting to do linux-stylo-debug instead of linux-debug-stylo as
having stylo at the end of -debug will require some additional changes
as some of our buildbot code checks for '-debug' at the end.
*oh* sigh.  reading fail.

Yes.  We do need a mozconfig for debug-stylo.
Attachment #8952913 - Flags: review?(frgrahl)
Attachment #8952913 - Attachment is obsolete: true
Attachment #8952913 - Flags: review?(frgrahl)
Attachment #8952959 - Flags: review?(frgrahl)
this time, w/ username
Attachment #8952959 - Attachment is obsolete: true
Attachment #8952959 - Flags: review?(frgrahl)
Attachment #8952961 - Flags: review?(frgrahl)
Attachment #8952961 - Flags: review?(frgrahl) → review+
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/228f05fcbd6c
Add debug-stylo mozconfigs r=frg
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Attachment #8928847 - Attachment description: [mozconfigs] nightly-stylo mozconfigs (v2) → [mozconfigs] nightly-stylo mozconfigs (v2) [checked-in]
Attachment #8952961 - Attachment description: [mozconfigs] add debug-stylo mozconfig → [mozconfigs] add debug-stylo mozconfig [checked-in]
Comment on attachment 8952643 [details] [diff] [review]
[configs] fixed configs to enable stylo for linux* and linux-debug only [checked-in]

Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-config/rev/80677b469cfbb49e47fee4abe342e7f7701cce36
Attachment #8952643 - Attachment description: [configs] fixed configs to enable stylo for linux* and linux-debug only → [configs] fixed configs to enable stylo for linux* and linux-debug only [checked-in]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
just realized that any future uploads  will be uploaded to the same
dir i.e. comm-central-trunk  and since the uploaded files are the same
(we don't differentiate stylobuilds and normal builds), this could be
problematic with people download tinderbox builds and expecting normal ones.
Attachment #8952976 - Flags: review?(frgrahl)
Comment on attachment 8952976 [details] [diff] [review]
[configs] tinderbox builds should be separated

r+ assuming ',' at the end of the list is valid.

> stylo,})
Attachment #8952976 - Flags: review?(frgrahl) → review+
,} valid python, but not PEP8 valid python. :P

fixed.
Attachment #8952979 - Flags: review+
Comment on attachment 8952979 [details] [diff] [review]
[configs] tinderbox builds should be separated [checked-in]

Pushed to buildbot-configs:
remote:   https://hg.mozilla.org/build/buildbot-configs/rev/39116a4b1f1fb9352f35cb5683aa8e8b7010f893
Attachment #8952979 - Attachment description: [configs] tinderbox builds should be separated → [configs] tinderbox builds should be separated [checked-in]
ok.. the selected builders are up.

keeping this bug opened until all platforms are included.
Status: REOPENED → ASSIGNED
Keywords: leave-open
Blocks: operation_st
reason being build/mozconfig.stylo disables stylo
Attachment #8953063 - Flags: review?(frgrahl)
Comment on attachment 8953063 [details] [diff] [review]
[mozconfigs] do not use build/mozconfig.stylo

r+ 

user missing in the patch :)
Attachment #8953063 - Flags: review?(frgrahl) → review+
Attachment #8953063 - Attachment is obsolete: true
Attachment #8953078 - Flags: review+
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/552fd5ab0b44
Do not use mozconfig.stylo as it disables stylo builds for linux-stylo r=frg
Pushed to buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/5435cfaef33b

Just enable building stylo on linux only.
Thanks to bug 1447611, these extra stylo builders are no longer necessary.  Stylo is now
built on by default and --disable-stylo has been removed.

Reverting all these changes.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → WONTFIX
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/e48b29d0f2bf
Backout --disable-stylo from mozconfigs. r=bustagefix
You need to log in before you can comment on or make changes to this bug.