setup builders to compile suite w/ stylo enabled

REOPENED
Assigned to

Status

SeaMonkey
Release Engineering
REOPENED
11 days ago
4 days ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [stylo])

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

11 days ago
At this point, we do not have stylo (and thus webrender) enabled on
all our builds.  This means we don't know what will happen if we
do. 

I'd like to have a set of builders w/ stylo enabled and using
just comm-central.
(Assignee)

Comment 1

11 days ago
Created attachment 8928115 [details] [diff] [review]
[mozconfigs] additional nightly-stylo mozconfigs
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8928115 - Flags: review?(frgrahl)
(Assignee)

Updated

11 days ago
Attachment #8928115 - Attachment is obsolete: true
Attachment #8928115 - Flags: review?(frgrahl)
(Assignee)

Comment 2

10 days ago
Created attachment 8928365 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs.

rationale for macosx64's mozconfig.  

We don't do cross-compile and since we don't need the disable stylo,
we might as well just directly use local-mozconfig.common
Attachment #8928365 - Flags: review?(frgrahl)
(Assignee)

Comment 3

10 days ago
Created attachment 8928368 [details] [diff] [review]
[configs] enable stylo builds for c-c only
Attachment #8928368 - Flags: review?(frgrahl)
Comment on attachment 8928365 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs.

> +ac_add_options --enable-webrender

I think this is the default now. Could you check.

r+ with this checked.

Keep in mind that we plan to do cross-compiles. If i find some time I will start with the configs soon. probably Nightly only first.
Attachment #8928365 - Flags: review?(frgrahl) → review+
Comment on attachment 8928368 [details] [diff] [review]
[configs] enable stylo builds for c-c only

> +        if platform in BRANCHES[branch]['platforms']

Missing/accidentally removed : I think.

r+ with nit fixed.
Attachment #8928368 - Flags: review?(frgrahl) → review+
(Assignee)

Comment 6

9 days ago
Created attachment 8928827 [details] [diff] [review]
[configs] fix nits
Attachment #8928368 - Attachment is obsolete: true
Attachment #8928827 - Flags: review+
(Assignee)

Comment 7

9 days ago
(In reply to Frank-Rainer Grahl (:frg) from comment #4)
> Comment on attachment 8928365 [details] [diff] [review]
> [mozconfigs] nightly-stylo mozconfigs.
> 
> > +ac_add_options --enable-webrender
> 
> I think this is the default now. Could you check.
> 
> r+ with this checked.
> 
> Keep in mind that we plan to do cross-compiles. If i find some time I will
> start with the configs soon. probably Nightly only first.

from https://hg.mozilla.org/mozilla-central/file/tip/toolkit/moz.configure#l850,

I suppose it means it is enabled by default.
(Assignee)

Comment 8

9 days ago
Created attachment 8928847 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs (v2)

since webrender is enabled by default,  no need for --enable-webrender..
(from https://hg.mozilla.org/mozilla-central/file/tip/toolkit/moz.configure#l850)
though I don't see it being disabled (aside from --disable-webrender).
Attachment #8928365 - Attachment is obsolete: true
Attachment #8928847 - Flags: review?(frgrahl)
Comment on attachment 8928847 [details] [diff] [review]
[mozconfigs] nightly-stylo mozconfigs (v2)

r+
Attachment #8928847 - Flags: review?(frgrahl) → review+

Comment 10

8 days ago
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/99accbe79a6d
Re-enable stylo/webrender building in suite using separate stylo mozconfigs. r=frg
Status: ASSIGNED → RESOLVED
Last Resolved: 8 days ago
Resolution: --- → FIXED
(Assignee)

Updated

8 days ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [stylo]
You need to log in before you can comment on or make changes to this bug.