1416998 - mach bootstrap doesn't update PATH on Windows

Status: NEW

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Mike Hommey [:glandium]]

IIRC, mach bootstrap updates things on Linux and Mac to have the .cargo/bin directory in PATH, but it doesn't do it on Windows, despite installing rust there.

Comment 1

[Honza Bambas (:mayhemer)]

Is the intention of this bug to add .cargo/bin to the user PATH env var?  First, you need admin rights to do that, second, I would like |mach bootstrap| to NOT change anything globally in my system, third, why is this even needed when I only build from inside the bash prompt that should have been set PATH correctly?

Comment 2

[Mike Hommey [:glandium]]

(In reply to Honza Bambas (:mayhemer) from comment #1)
> why is this even needed when I only build from inside the bash prompt that should have
> been set PATH correctly?

That's the point. It's not set in bash, and on Linux and mac, the .bashrc or .profile or whatever is modified to have PATH set. So why not on Windows too?

Comment 3

[Honza Bambas (:mayhemer)]

(In reply to Mike Hommey [:glandium] from comment #2)
> (In reply to Honza Bambas (:mayhemer) from comment #1)
> > why is this even needed when I only build from inside the bash prompt that should have
> > been set PATH correctly?
> 
> That's the point. It's not set in bash, and on Linux and mac, the .bashrc or
> .profile or whatever is modified to have PATH set. So why not on Windows too?

Ah, so it's missing only in bash.  Thanks for clarifying it.  I'm just curios why everything works correctly even now.

Comment 4

[(not currently active) Ted Mielczarek]

Alternately, I should just land my patch in bug 1396993.