14170 - OJI causes service manager leak

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect, P1)

Description

[vidur (gone)]

It seems that the NSGetFactory for the OJI DLL maintains a reference to the
service manager
(http://lxr.mozilla.org/seamonkey/source/modules/oji/src/nsCJVMManagerFactory.cp
p#112) but never releases it. The resulting service manager leak results in many
more downstream leaks.

Comment 1

[edburns]

*** Bug 8178 has been marked as a duplicate of this bug. ***

Comment 2

[mark.lin]

Hmm... I don't understand why we need to cache a global reference to the service
manager. It is only used in one method, NSGetFactory().

Comment 3

[vidur (gone)]

Actually, it's used in other files in the same module (see JVM_GetJVMMgr(), for
example).

Comment 4

[edburns]

How do I obtain a reference to the ServiceManager on demand?  There is no case
when I can release it so I could implement a strategy where I just re-obtain
and release it every time I need to use it.  Can I just save the
nsIServiceManager reference I receive from NSGetFactory()?

Comment 5

[edburns]

Instead of asking for the ServiceManager and invoking methods from it, why
can't I just use nsServiceManeger static methods, as is done in all the files
returned in the query
 http://lxr.mozilla.org/mozilla/search?string=ServiceManager

Ed

Comment 6

[edburns]

Attachment: Fix for bug 14170

Comment 7

[edburns]

Warren beat me to the punch.