Location bar overlaps the "tip" notification box

NEW
Unassigned

Status

()

defect
P2
minor
2 years ago
2 years ago

People

(Reporter: emilghitta, Unassigned)

Tracking

(Blocks 1 bug, {regression})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 unaffected, firefox58 fix-optional, firefox59 fix-optional)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment, 1 obsolete attachment)

Posted image Tip.gif (obsolete) —
[Affected versions]:
59.0a1 (BuildId:20171113220112)
58.0b3 (BuildId:20171114032831)

[Unaffected versions]:
57.0 (BuildId:20171112125346)

[Affected platforms]:
Windows 10 64bit.
macOS 10.12.
Ubuntu 16.04 64bit.

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Resize Firefox.
3. Write something inside the location bar.

[Expected result]:
The "tip" notification box is properly displayed.

[Actual result]:
The "tip" notification box is displayed under the location bar.

[Regression range]:

This is a regression:

Last good revision: c5695ec7ac409ad20c0076197cdeb3e792f26ef1
First bad revision: 6d50619818688955eb9dcb980a3b666521a8cf1b

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c5695ec7ac409ad20c0076197cdeb3e792f26ef1&tochange=6d50619818688955eb9dcb980a3b666521a8cf1b

[Additional notes]:
For further details regarding this issue please observe the attached screencast.
Reporter

Comment 1

2 years ago
Hi Marco!

Can you please have a look into this?

Thanks!
Blocks: 1367790
Flags: needinfo?(mak77)
This bug pretty much exists from when we added the new notification, the only reason it's now more evident is that by removing the old notification the panel has shrinked a bit in height. Indeed it's a <deck>, and as such it takes the height of the tallest content, that was the old opt-in notification.
We could probably increase the height of the bar to mitigate it a bit (more padding maybe?).
IIRC the fancy overlapping is due to the mixture of flexboxes we use here (both xul and html), that is necessary to keep the text visible in such small windows.
P2 because it sounds like the solution could be a simple oneline of css.
Flags: needinfo?(mak77)
Priority: -- → P2
Whiteboard: [fxsearch]
Reporter

Updated

2 years ago
Attachment #8928113 - Attachment is obsolete: true
Reporter

Comment 3

2 years ago
Posted image tip.gif
You need to log in before you can comment on or make changes to this bug.