Closed
Bug 1417086
Opened 8 years ago
Closed 8 years ago
handler404 should accept 'exception'
Categories
(Socorro :: Symbols, task)
Socorro
Symbols
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Assigned: peterbe)
Details
Attachments
(1 file)
See https://irccloud.mozilla.com/pastebin/Wv5cWWsZ/
Basically, when you write your own, instead of django.views.defaults.page_not_found, you're supposed to accept an 'exception' second argument.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
I'm not able to reproduce it. Even with DEBUG=False and running with Gunicorn.
But the way Django 1.11.7 handles it, they're very gentle around handler404 functions that raise a TypeError.
https://github.com/django/django/blob/1.11.7/django/core/handlers/exception.py#L110-L116
So I suspect NewRelic incorrectly scoops up this exception when it's supposed to be swallowed.
Comment 3•8 years ago
|
||
Comment 4•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla-services/tecken
https://github.com/mozilla-services/tecken/commit/dfa656ca782d66a0de365995995f98dab611b664
fixes bug 1417086 - handler404 should accept 'exception' (#559)
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•