51 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
See https://irccloud.mozilla.com/pastebin/Wv5cWWsZ/ Basically, when you write your own, instead of django.views.defaults.page_not_found, you're supposed to accept an 'exception' second argument.
I'm not able to reproduce it. Even with DEBUG=False and running with Gunicorn. But the way Django 1.11.7 handles it, they're very gentle around handler404 functions that raise a TypeError. https://github.com/django/django/blob/1.11.7/django/core/handlers/exception.py#L110-L116 So I suspect NewRelic incorrectly scoops up this exception when it's supposed to be swallowed.
Created attachment 8928186 [details] [review] Link to GitHub pull-request: https://github.com/mozilla-services/tecken/pull/559
Commit pushed to master at https://github.com/mozilla-services/tecken https://github.com/mozilla-services/tecken/commit/dfa656ca782d66a0de365995995f98dab611b664 fixes bug 1417086 - handler404 should accept 'exception' (#559)
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.