Closed
Bug 1417093
Opened 6 years ago
Closed 6 years ago
Remove symlink support from nsZipArchive implementation
Categories
(Core :: Networking: JAR, enhancement, P3)
Core
Networking: JAR
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
The symlink code in nsZipArchive and friends is unused (we only run that bit of the zip code on our own stuff, and we wouldn't ship files with symlinks) and has issues, so we should remove it to improve code clarity etc.
Updated•6 years ago
|
Assignee: nobody → xeonchen
Priority: -- → P3
Whiteboard: [necko-triaged]
Assignee | ||
Comment 1•6 years ago
|
||
Oh, I was looking at an old load of this bug, and didn't see that it got assigned, so I wrote a patch earlier today - hope you don't mind! Feel free to steal the review...
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8930542 [details] Bug 1417093 - remove symlink support from our nsZipArchive extract implementation because it's unused and has issues, https://reviewboard.mozilla.org/r/201668/#review207518
Attachment #8930542 -
Flags: review?(dtownsend) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/98693808d633 remove symlink support from our nsZipArchive extract implementation because it's unused and has issues, r=mossop
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/98693808d633
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•