1417197 - Don't hit fallback for simple nsDisplayThemedBackground cases

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Markus Stange [:mstange]]

This patch adds nsITheme::CreateWebRenderCommands and implements it on macOS.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1417197 - Create nsITheme::CreateWebRenderCommands in order to optimize simple theme fills, and add a Mac implementation.

Review commit: https://reviewboard.mozilla.org/r/199492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199492/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8928275 [details]
Bug 1417197 - Create nsITheme::CreateWebRenderCommands in order to optimize simple theme fills, and add a Mac implementation.

https://reviewboard.mozilla.org/r/199492/#review204590

::: widget/cocoa/nsNativeThemeCocoa.mm:3031
(Diff revision 1)
> +        ThemeGeometryType type = ThemeGeometryTypeForWidget(aFrame, aWidgetType);
> +        aBuilder.PushRect(bounds, bounds, true,
> +                          wr::ToColorF(VibrancyFillColor(aFrame, type)));
> +      } else {
> +        aBuilder.PushRect(bounds, bounds, true,
> +                          wr::ToColorF(Color(0.996, 1.000, 0.792, 0.950)));

Can you say where these come from?

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1417197 - Create constants for hardcoded theme fill colors.

Review commit: https://reviewboard.mozilla.org/r/199498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199498/

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8928284 [details]
Bug 1417197 - Create constants for hardcoded theme fill colors.

https://reviewboard.mozilla.org/r/199498/#review204604

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7af7d6aba30
Create nsITheme::CreateWebRenderCommands in order to optimize simple theme fills, and add a Mac implementation. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/4eebab7d065e
Create constants for hardcoded theme fill colors. r=jrmuizel

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d7af7d6aba30
https://hg.mozilla.org/mozilla-central/rev/4eebab7d065e