Pinned tabs are too wide in compact mode

VERIFIED FIXED in Firefox 58

Status

()

Firefox
Tabbed Browser
P3
normal
VERIFIED FIXED
10 days ago
2 days ago

People

(Reporter: rugk, Assigned: dao)

Tracking

({regression})

57 Branch
Firefox 59
regression
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed, firefox59 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

10 days ago
Created attachment 8928310 [details]
pinnedTabWidth.png

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171030111120

Steps to reproduce:

Upgraded to Firefox 57 (with Fedora 27). I also changed the setting in the customization to use the "compact" mode.


Actual results:

The icons of the websites are square ones, but the rectangular tabs, which are meant to save space, have a big width. In touch mode this may make sense, but not in the compact mode.

Compared to Australis the width of these tabs did increase, although the "heavy stylistic elements" of Australis' curved tabs were removed. So one would have expected these pinned tabs to have a smaller width too, but no…


Expected results:

Let these icons to be square and do not add empty space around these pinned tabs. For the "usual" tabs everything looks good/okay, but not for these pinned tabs. They really have a big width.

Also note that pinned tabs are often used to pin services/websites, which should stay open and are known to the user, are frequently used and should only be one click away. That's the whole reason why they only show the icon.
So they do not need all this empty space surrounding them. 

Additionally they can/may be a lot and when you have only 4 tabs open already 1/7th of the width of my 1920x1080px screen are used for these. And 4 ones are not a lot, IMHO.

Updated

10 days ago
Component: Untriaged → Tabbed Browser
(Assignee)

Updated

10 days ago
Assignee: nobody → dao+bmo
Status: UNCONFIRMED → ASSIGNED
status-firefox57: --- → wontfix
status-firefox58: --- → affected
status-firefox59: --- → affected
Ever confirmed: true
Keywords: regression
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Pinned tabs in photon are too width → Pinned tabs are too wide in compact mode
(Assignee)

Updated

10 days ago
Depends on: 1354332
(Assignee)

Updated

10 days ago
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 2

8 days ago
mozreview-review
Comment on attachment 8928493 [details]
Bug 1417248 - Make pinned tabs smaller in compact mode.

https://reviewboard.mozilla.org/r/199750/#review205386

Works for me, thanks!
Attachment #8928493 - Flags: review?(jhofmann) → review+

Comment 3

8 days ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4417906600fb
Make pinned tabs smaller in compact mode. r=johannh

Comment 4

8 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4417906600fb
Status: ASSIGNED → RESOLVED
Last Resolved: 8 days ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=a3f183201f7f183c263d554bfb15fbf0b0ed2ea4&newProject=mozilla-central&newRev=249a8177ad915734b83c357d49213e26d889b377&filter=pinned
(Reporter)

Comment 6

4 days ago
Uuugh, what? Can only see text at your link… https://screenshots.firefox.com/aFEhmqJRGDO3jSkX/screenshots.mattn.ca

But BTW, anyway, thanks for fixing that so fast!

Comment 7

3 days ago
I have reproduced this bug with Nightly 59.0a1 (2017-11-14) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20171121100129
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [bugday-20171115]
(Assignee)

Updated

3 days ago
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
(Assignee)

Comment 8

3 days ago
Comment on attachment 8928493 [details]
Bug 1417248 - Make pinned tabs smaller in compact mode.

Approval Request Comment
[Feature/Bug causing the regression]: Firefox 57 theme and compact mode
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple fix
[String changes made/needed]: /
Attachment #8928493 - Flags: approval-mozilla-beta?
Comment on attachment 8928493 [details]
Bug 1417248 - Make pinned tabs smaller in compact mode.

Polish a pinned tabs issue in compact mode. Beta58+.
Attachment #8928493 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/bf0feade9571
status-firefox58: affected → fixed
You need to log in before you can comment on or make changes to this bug.