1417277 - remove support for MOZPSM_NSSDBDIR_OVERRIDE

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

MOZPSM_NSSDBDIR_OVERRIDE was added in bug 462919 for integration with xulrunner applications. Upcoming changes we're aiming to make with how PSM handles NSS and the certificate/key databases (e.g. making the sqlite-backed implementation mandatory) mean we have to take this feature into account. xulrunner isn't supported any longer. Searching the web for "MOZPSM_NSSDBDIR_OVERRIDE" yields two kinds of results: mozilla-central source code and a man page for nss-gui, which it seems is the only project that ever made use of MOZPSM_NSSDBDIR_OVERRIDE (and hasn't been updated since 2013, from what I can tell). I think it's fair to conclude that this isn't a widely-used (let alone known) feature. To make development easier, we should remove it.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 1417277 - remove support for MOZPSM_NSSDBDIR_OVERRIDE

MOZPSM_NSSDBDIR_OVERRIDE was added in bug 462919 for integration with xulrunner
applications. Upcoming changes we're aiming to make with how PSM handles NSS and
the certificate/key databases (e.g. making the sqlite-backed implementation
mandatory) mean we have to take this feature into account. xulrunner isn't
supported any longer. Searching the web for "MOZPSM_NSSDBDIR_OVERRIDE" yields
two kinds of results: mozilla-central source code and a man page for nss-gui,
which it seems is the only project that ever made use of
MOZPSM_NSSDBDIR_OVERRIDE (and hasn't been updated since 2013, from what I can
tell). I think it's fair to conclude that this isn't a widely-used (let alone
known) feature. To make development easier, we should remove it.

Review commit: https://reviewboard.mozilla.org/r/199554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199554/

Comment 2

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8928342 [details]
bug 1417277 - remove support for MOZPSM_NSSDBDIR_OVERRIDE

https://reviewboard.mozilla.org/r/199554/#review205048

The poor https://fedorahosted.org/nss-gui/ site is not even online anymore. r+, goodbye env var!

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d62ecf6c116
remove support for MOZPSM_NSSDBDIR_OVERRIDE r=jcj

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5d62ecf6c116