Closed Bug 1417305 Opened 2 years ago Closed 2 years ago

Some ChannelMediaDecoder::ResourceCallback::NotifyDataEnded() cleanup

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/dom/media/ChannelMediaDecoder.cpp#114-123

Since ResourceCallback::NotifyDataEnded() is the only caller of ChannelMediaDecoder::NotifyDownloadEnded(), we can move #114-#123 into NotifyDownloadEnded() to make the code more readable.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8928396 - Flags: review?(bechen)
Attachment #8928397 - Flags: review?(bechen)
Attachment #8928398 - Flags: review?(bechen)
Comment on attachment 8928396 [details]
Bug 1417305. P1 - let callers of MediaResourceCallback::NotifyDataEnded() decide whether to call it synchronously.

https://reviewboard.mozilla.org/r/199608/#review204720
Attachment #8928396 - Flags: review?(bechen) → review+
Comment on attachment 8928397 [details]
Bug 1417305. P2 - move some code from NotifyDataEnded() into NotifyDownloadEnded() to make the code more readable.

https://reviewboard.mozilla.org/r/199610/#review204722
Attachment #8928397 - Flags: review?(bechen) → review+
Comment on attachment 8928398 [details]
Bug 1417305. P3 - treat NS_BASE_STREAM_CLOSED as success.

https://reviewboard.mozilla.org/r/199612/#review204724
Attachment #8928398 - Flags: review?(bechen) → review+
Attachment #8928396 - Flags: review?(gsquelart)
Attachment #8928397 - Flags: review?(gsquelart)
Attachment #8928398 - Flags: review?(gsquelart)
Comment on attachment 8928396 [details]
Bug 1417305. P1 - let callers of MediaResourceCallback::NotifyDataEnded() decide whether to call it synchronously.

https://reviewboard.mozilla.org/r/199608/#review204736
Attachment #8928396 - Flags: review?(gsquelart) → review+
Comment on attachment 8928397 [details]
Bug 1417305. P2 - move some code from NotifyDataEnded() into NotifyDownloadEnded() to make the code more readable.

https://reviewboard.mozilla.org/r/199610/#review204738
Attachment #8928397 - Flags: review?(gsquelart) → review+
Comment on attachment 8928398 [details]
Bug 1417305. P3 - treat NS_BASE_STREAM_CLOSED as success.

https://reviewboard.mozilla.org/r/199612/#review204742
Attachment #8928398 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11fdb4965fa1
P1 - let callers of MediaResourceCallback::NotifyDataEnded() decide whether to call it synchronously. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/07d135dc471e
P2 - move some code from NotifyDataEnded() into NotifyDownloadEnded() to make the code more readable. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/f4fa9fab2f3e
P3 - treat NS_BASE_STREAM_CLOSED as success. r=bechen,gerald
You need to log in before you can comment on or make changes to this bug.