1417319 - Fix creating packages for thunderbird et al when building with m-c as topdir.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Tom Prince [:tomprince]]

For some reason, building packages with m-c as topdir via mach is broken.

It looks like there is a missing dependency between locale-manifest.in and package-manifest.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1417319: Remove use of MOZ_PKG_MANIFEST_P for MOZ_PKG_MANIFEST.

mozilla-central switched to handling the preprocessing in mozpack some time
ago, so we can get rid of our preprocessing step. There was some missing
dependencies that caused this to fail when building with m-c as topdir.

Review commit: https://reviewboard.mozilla.org/r/199640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199640/

Comment 2

[Edmund Wong (:ewong)]

Comment on attachment 8928416 [details]
Bug 1417319: Remove use of MOZ_PKG_MANIFEST_P for MOZ_PKG_MANIFEST.

https://reviewboard.mozilla.org/r/199638/#review204728

::: suite/installer/Makefile.in:221
(Diff revision 1)
>  endif
>  
>  package-compare:: $(MOZ_PKG_MANIFEST)
> -ifdef MOZ_PKG_MANIFEST_P
>  	cd $(DIST); find $(PKGCOMP_FIND_OPTS) $(FINDPATH) -type f | sort > bin-list.txt
> -	grep "^$(BINPATH)" $(MOZ_PKG_MANIFEST) | sed -e 's/^\///' | sort > $(DIST)/pack-list.txt
> +	$(call py_action,preprocessor,$(DEFINES) $(ACDEFINES) $(MOZ_PKG_MANIFEST)) | grep '^$(BINPATH)' | sed -e 's/^\///' | sort > $(DIST)/pack-list.txt

just wondering..  with single quotes.. would
${BINPATH} be expanded?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8928416 [details]
Bug 1417319: Remove use of MOZ_PKG_MANIFEST_P for MOZ_PKG_MANIFEST.

https://reviewboard.mozilla.org/r/199640/#review204812

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4fd7237c5c2f
Remove use of MOZ_PKG_MANIFEST_P for MOZ_PKG_MANIFEST; r=Fallen