1417344 - Clean up HTMLEditor::InsertBR

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

- out parameter is unused.
- We should use 3rd parameter of CreateBR for collapse.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1417344 - Clean up HTMLEditor::InsertBR.

No one uses out parameter of InsertBR, so we should remove it.  Also, CreateBR
has direction parameter for selection, so we should use it.

Review commit: https://reviewboard.mozilla.org/r/200112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200112/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8928829 [details]
Bug 1417344 - Clean up HTMLEditor::InsertBR.

https://reviewboard.mozilla.org/r/200112/#review205312

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d56e0d42f4a
Clean up HTMLEditor::InsertBR. r=masayuki

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out for failing  test_appinfo.py TestAppInfo.test_invalid_properties .

Push that started failing: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0d56e0d42f4a54e2026274552b791620e2c4b6ac&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-searchStr=en-us

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=145457201&repo=autoland

Backout push: https://hg.mozilla.org/integration/autoland/rev/84de6459e4cd0e2de7dd044f19f430e5bd7f9b40


[task 2017-11-17T01:48:27.725Z] 01:48:27     INFO - TEST-UNEXPECTED-ERROR | test_appinfo.py TestAppInfo.test_invalid_properties | UnknownException: [Exception... "The URI is malformed"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: chrome://marionette/content/listener.js :: get/< :: line 1153"  data: no]
[task 2017-11-17T01:48:27.726Z] 01:48:27     INFO - stacktrace:
[task 2017-11-17T01:48:27.726Z] 01:48:27     INFO - 	get/<@chrome://marionette/content/listener.js:1153:7
[task 2017-11-17T01:48:27.727Z] 01:48:27     INFO - 	navigate/<@chrome://marionette/content/listener.js:410:13
[task 2017-11-17T01:48:27.728Z] 01:48:27     INFO - 	async*navigate@chrome://marionette/content/listener.js:409:13
[task 2017-11-17T01:48:27.728Z] 01:48:27     INFO - 	get@chrome://marionette/content/listener.js:1152:5
[task 2017-11-17T01:48:27.731Z] 01:48:27     INFO - Traceback (most recent call last):
[task 2017-11-17T01:48:27.733Z] 01:48:27     INFO -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 137, in run
[task 2017-11-17T01:48:27.733Z] 01:48:27     INFO -     self.setUp()
[task 2017-11-17T01:48:27.734Z] 01:48:27     INFO -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/firefox_puppeteer/mixins.py", line 91, in setUp
[task 2017-11-17T01:48:27.734Z] 01:48:27     INFO -     self.marionette.navigate('about:')
[task 2017-11-17T01:48:27.734Z] 01:48:27     INFO -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 1632, in navigate
[task 2017-11-17T01:48:27.735Z] 01:48:27     INFO -     self._send_message("get", {"url": url})
[task 2017-11-17T01:48:27.735Z] 01:48:27     INFO -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/decorators.py", line 23, in _
[task 2017-11-17T01:48:27.736Z] 01:48:27     INFO -     return func(*args, **kwargs)
[task 2017-11-17T01:48:27.736Z] 01:48:27     INFO -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 740, in _send_message
[task 2017-11-17T01:48:27.736Z] 01:48:27     INFO -     self._handle_error(err)
[task 2017-11-17T01:48:27.738Z] 01:48:27     INFO -   File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 764, in _handle_error
[task 2017-11-17T01:48:27.738Z] 01:48:27     INFO -     raise errors.lookup(error)(message, stacktrace=stacktrace)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40bf7c21792a
Clean up HTMLEditor::InsertBR. r=masayuki on a CLOSED TREE

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/40bf7c21792a