Closed Bug 1417373 Opened 3 years ago Closed 3 years ago

Didn't set the value of Cr texture's D3D11_TEXTURE2D_DESC

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

Unspecified
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kechen, Assigned: kechen)

Details

Attachments

(1 file)

Not sure if this makes any difference, but looks like the D3D11_TEXTURE2D_DESC setting is skipped here[1].

[1] https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/gfx/layers/D3D11YCbCrImage.cpp#209
Comment on attachment 8928472 [details]
Bug 1417373 - Add initialize setting to texture Cb's property description;

https://reviewboard.mozilla.org/r/199730/#review204800

it is not necessary as the D3D11_TEXTURE2D_DESC value is identical between the Cb and Cr plan (it was created that way)

but I guess this makes it clearer.
Attachment #8928472 - Flags: review?(jyavenard) → review+
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f28b8bb46e76
Add initialize setting to texture Cb's property description; r=jya
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f28b8bb46e76
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.