Closed Bug 1417386 Opened 3 years ago Closed 3 years ago

Empty-named folders on the bookmarks toolbar have too much space on their right

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox58 --- verified
firefox59 --- verified

People

(Reporter: mak, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Steps to reproduce:
1. clear the name of a bookmarks folder through the properties dialog
2. do the same for a normal bookmarked url
3. note the folder has too much empty space on the right
Blocks: 1417364
Summary: Empty-named folders on the toolbar have too much space on their right → Empty-named folders on the bookmarks toolbar have too much space on their right
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment on attachment 8928485 [details]
Bug 1417386 - Remove bogus end pedding from bookmarks toolbar folders without a label.

https://reviewboard.mozilla.org/r/199734/#review204832

Thank you!
Attachment #8928485 - Flags: review?(mak77) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60b9a18aabbf
Remove bogus end pedding from bookmarks toolbar folders without a label. r=mak
https://hg.mozilla.org/mozilla-central/rev/60b9a18aabbf
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment on attachment 8928485 [details]
Bug 1417386 - Remove bogus end pedding from bookmarks toolbar folders without a label.

Approval Request Comment
[Feature/Bug causing the regression]: /
[User impact if declined]: bookmark folders without a label consume more space than they should, making bug 1417364 worse
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /
Attachment #8928485 - Flags: approval-mozilla-beta?
Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on the latest Nightly build? Thanks!
Flags: needinfo?(brindusa.tot)
Build ID: 20171116220410
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Verified as fixed on Firefox Nightly 59.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: needinfo?(brindusa.tot)
Comment on attachment 8928485 [details]
Bug 1417386 - Remove bogus end pedding from bookmarks toolbar folders without a label.

Fix a bookmark issue and was verified. Beta58+.
Attachment #8928485 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Build ID: 20171120142222
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox 58.0b5 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.